Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing multiple keyrefs constraints #396

Open
SmartLayer opened this issue Oct 26, 2020 · 2 comments
Open

missing multiple keyrefs constraints #396

SmartLayer opened this issue Oct 26, 2020 · 2 comments
Assignees
@darakhbharat

Comments

@SmartLayer
Copy link

  1. contract name keyref is not set up.
@darakhbharat
Copy link
Contributor

Below are the list of possible elements where "contract" attribute occurs. Now need to update the schema to check if its respective <ts:contract name="" .../> element should occur in XML.

<ts:ethereum contract="unicon"/>
<ethereum:call function="redeemed" contract="unicon" as="bool">
<ethereum:transaction function="setText" contract="PublicResolver" as="bool">
<ethereum:event type="NameRegistered" contract="ETHRegistrarController" filter="label=${tokenId}" select="name"/>

@SmartLayer SmartLayer changed the title missing multiple keyrefs missing multiple keyrefs constraints Oct 27, 2020
@darakhbharat
Copy link
Contributor

  1. contract name keyref is not set up.
    This is completed and tested with changes - darakhbharat@38a09be

Added ts:contract/@name reference check for above mentioned elements.

We can directly merge this changes to master as these works on schema 1.0 and are independent of XSD 1.1 validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darakhbharat darakhbharat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SmartLayer @darakhbharat