-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapraid 10.x vs 11.x #12
Comments
Thanks for the analysis. |
Hi, got into further details of the config codes you got, so i'd probably refactor it so that it honours existing config structure, instead of rewriting, and the code would be something like that:
The (InMemory)ConfigFileHelper would possibly have methods:
Also since we manage the thjings in memory, I'd possibly have an InMemoryConfigFile (array of strings) and would decouple writing. To minimize changes, possibly the CurrentConfigFileHelper public methods should be kept and the necessary changes done just by calling the InMemoryConfigFile methods... Also it's likely that from a given point only breaking changes in SnapRAID should make necessary to do changes in Elucidate...(this config thing is the one that should help to achieve that)... |
MAJOR CHANGE: This is the reason why a new config (manually created) is not recognized via Elucidate. But according snapraid documents: In the configuration file 'data' is now a synonymous of 'disk' as ov ver. 10.0 - so we still might use DISK in the config...but this might change in the future, so it'd be wise to switch to "data". Also to note:
|
TODO (summary of my notes above):
|
- Add double click and menu to edit 'Name' - MessageBox warning before proceeding
What are the breaking changes?
Start:
Elucidate does execute the snapraid exe via arguments.
Were those arguments changed between versions (IMO: not, it seems to work - if yes, which ones)
Config:
If elucidate will focus just on some values and will be able to alter only that potion of the config file, it could become more stable. Actually for those people who have even bigger aversion to text config files than me, the basic setup GUI will do.
The only extra functions i've used: autosave 250.
Btw. any date when 11.x changes will be analyzed and implemented?
The text was updated successfully, but these errors were encountered: