-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce limit parameter in QES read method #485
base: main
Are you sure you want to change the base?
Conversation
create_package |
Created package with number |
Coverage Report
|
create_package |
Created package with number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with this, only thing I didn't get is in the comment. Should be good to go after that one is resolved
) | ||
|
||
return result | ||
data = itertools.chain.from_iterable(data) | ||
if limit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm but we did apply the limit in the query already? why do we apply it twice here?
This PR introduces the ability to limit the results returned by the QES.
As part of this enhancement, the AstraClient has been refactored. The most notable change is the replacement of the
concat
method for MetaFrames with a call toitertools.chain.from_iterable