-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zaps using ligess not working #1397
Comments
NWC protocol is |
Fixed the URL, which is now accepted by nostter. However, if I zap a note, nothing is coming in to my zapper relay. After this the logging stops. I tried zapping the same note on Amethyst, and I see the invoice being sent to the zapper relay to be paid. I renamed the issue to track general compatibility issues. Awesome client btw to be able to handle 2500 follows. |
|
[edit] changed a bit, had to re-read stuff as I implemented it ages ago. Yes, that is intended, as it's a relay only used for zaps so it want to AUTH the user. I can disable it to test it, but I think it's prudent to have the relay shielded off a bit more. It used to be mentioned in NIP-57 IIRC, but in the current version of the NIP it's not mentioned anymore, not sure why? |
Okay, I'll support AUTH on NWC. |
Done. Could you please check? |
I've added logging on my side, it looks like it connects to the relay and sends the encrypted invoice but no NIP-42 AUTH response yet. I cleared my browser cache to make sure I have the latest version.
It holds off on processing the invoice until the AUTH response is received, and the connection is closed after 10 seconds if this doesn't happen. |
Hmm... I'll check it out. |
Sorry, I had the wrong option, could you please check again? |
It works 🥇 Only thing is that the zap dialog stays open. On refresh the zap is shown on the notifications of the note.
The last log in the console is |
The Zap dialog is closed when kind 23195 EVENT comes back from the relay. If received: Lines 34 to 35 in 89eb1be
|
Thank you for the investigation. I added some extra logging on my end and noticed the 23195 event wasn't actually sent back. I fixed that, but it still doesn't seem to arrive, I don't see a Logging from my end shows the event is now being sent, but I have to look into it to see if it's actually correct. It was missing a
What I noticed when testing a zap with Amethyst is that it also doesn't seem to close the zap process, I guess it's also waiting for this event. So the remaining issue is probably on my end. |
Thanks. The message seems not to contain subscription id |
Ah, this is all new stuff, added to NIP-47 after I wrote ligess. I guess Amethyst doesn't care or has fallback mechanism to the old style, but nostter is way more strict, which is good. I think this issue can be closed now, I hope you don't mind if I continue zapping you for testing 😆 Thank you for your patience and once again thanks for your work on this awesome client! |
One more comment: I think I fixed the response. If I zap a note, it closes the dialog so that's good. It looks like it's decoded properly, with the correct result object containing the preimage. 👍 The only thing that I don't see is that the zap notification is shown under the note (in thread view). It does shows up after a page reload. |
Congratulations🎉 |
When trying to add the NWC string from my ligess instance, it is not accepted and
[invalid NWC URI]
is logged.The format is:
This URL works in Amethyst, but it's not clear why it's not accepter by nostter.
The text was updated successfully, but these errors were encountered: