Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify logging process to avoid additional import in files in which we wish to log #77

Closed
sfc-gh-twhite opened this issue Dec 5, 2024 · 0 comments · Fixed by #88

Comments

@sfc-gh-twhite
Copy link
Collaborator

I mentioned on a comment in #55 that we should look to simplify the usage of gateway_logger to avoid needing to import logging in all of the files which require logging.

This can be resolved standalone from #55, so isolating the comment with this issue.

it looks something like this, requiring an additional import anywhere we wish to log:

import logging

gateway_logger.log(logging.DEBUG, "Cortex Request URL\n", url, block=True)

It might be nice if we could do:

gateway_logger.log("DEBUG", "Cortex Request URL\n", url, block=True)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant