Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): réutilisation du composant autocomplete sur la home, accentuation du contraste quand on parcours les suggestions au clavier #6429

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

fix(autocomplete): réutilisation du composant autocomplete sur la home, accentuation du contraste quand on parcours les suggestions au clavier #6429

wants to merge 9 commits into from
+224 −292

Conversation

carolineBda
Copy link
Contributor

Fix #6403

@carolineBda
fix(autocomplete): réutilisation du composant autocomplete sur la hom…
184486a 
…e, accentuation du contraste quand on parcours les suggestions au clavier
@carolineBda
fix test
b25f30f
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 21, 2025 16:21 Destroyed
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 21, 2025 16:30 Destroyed
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 21, 2025 16:38 Destroyed
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 27, 2025 08:54 Destroyed
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 27, 2025 10:31 Destroyed
carolineBda
carolineBda commented Jan 27, 2025
View reviewed changes
packages/code-du-travail-frontend/src/modules/common/Autocomplete/Autocomplete.tsx Outdated
{displayLabel(item)}
</Button>
{lineAsLink ? (
<Link href={lineAsLink(item)} className={link}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai transformé le bouton en Link directement pour que le style soit uniforme partout

Viczei
Viczei reviewed Jan 27, 2025
View reviewed changes
packages/code-du-travail-frontend/src/modules/home/__tests__/HomeSearch.test.tsx
@@ -52,6 +52,7 @@ describe("<HomeSearch />", () => {
expect(getByText("congés payés et maladie")).toBeInTheDocument();

userAction.click(congesSansSolde);
fireEvent.submit(byTestId("search-input").get());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plutôt qu'un testid, ca pourrait être cool de récupérer l'input par son label

Suggested change
fireEvent.submit(byTestId("search-input").get());
fireEvent.submit(byLabelText("Recherchez par mots-clés").get());

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'ai essayer mais ça marche pas. Je penses que c'est parce que le label est comme ça :

  <label
      class="fr-label"
      for="input-:r1:"
   >
      Recherchez par mots-clés
      <span
        class="fr-hint-text"
      >
        par exemple : congés payés, durée de préavis
      </span>
    </label>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah oui en effet, peut être mettre en regex dans ce cas

@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 27, 2025 11:04 Destroyed
@tokenbureau tokenbureau bot temporarily deployed to review-carolinebda-rgaa-combobox-3v16cz January 27, 2025 11:09 Destroyed
carolineBda
carolineBda commented Jan 27, 2025
View reviewed changes
packages/code-du-travail-frontend/src/modules/layout/header/SearchInput.tsx Outdated
@@ -61,7 +65,7 @@ export const SearchInput = (props: Props) => {
/>
<ul
{...getMenuProps({
className: list,
className: autocompleteListContainer,
Copy link
Contributor Author

@carolineBda carolineBda Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je réutilise les même styles

@carolineBda carolineBda requested a review from m-maillot January 27, 2025 11:13
@tokenbureau
Copy link

tokenbureau bot commented Jan 27, 2025

🎉 Deployment for commit a4cbdf9 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/code-du-travail-numerique/app:sha-a4cbdf963582a5d79230bb06bea5a1ea8667e434
Debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viczei Viczei Viczei approved these changes

@m-maillot m-maillot Awaiting requested review from m-maillot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Visibilité du focus clavier sur les listbox des combobox
2 participants
@carolineBda @Viczei