New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify all headings in sections to be valid #391

Open

carolineBda opened this issue Jan 4, 2023 · 0 comments

Labels

bug

Contributor

carolineBda commented Jan 4, 2023

Issue to fix
Htlm is invalid here :
https://code.travail.gouv.fr/fiche-ministere-travail/entreprises-dinsertion-ei
but valid on source page
https://travail-emploi.gouv.fr/emploi-et-insertion/insertion-activite-economique/article/entreprises-d-insertion-ei

Solution
Currently in our page, headings are one less further than on source site as on source H1 is always the link to home.
When we parse the html of each sections, we should transform every decrement every headings with one :
https://github.com/SocialGouv/fiches-travail-data/blob/master/src/fetch-data/parseDom.js#L209

carolineBda added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment