Update GameBoard.java #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed the issue where the last successful hit wouldn't change to the correct color, turning orange instead of red. This was resolved by manually setting the color of the last position to red before displaying the message. In the original code, when someone got a correct hit, the tile would turn red. The problem stemmed from this code turning the tile red wouldn't occur when someone won due to the if-else structure of this part of the code. As such, manually setting the tile to red when displaying the victory screen resolves this issue.
|
Copied from my branch: Addressed the issue (#32) where the last successful hit wouldn't change to the correct color, turning orange instead of red. This was resolved by manually setting the color of the last position to red before displaying the message. In the original code, when someone got a correct hit, the tile would turn red. The problem stemmed from this code turning the tile red wouldn't occur when someone won due to the if-else structure of this part of the code. As such, manually setting the tile to red when displaying the victory screen resolves this issue. |
|
Good job! Thank you for another contribution 😃 |
Sokom141
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed the issue where the last successful hit wouldn't change to the correct color, turning orange instead of red. This was resolved by manually setting the color of the last position to red before displaying the message. In the original code, when someone got a correct hit, the tile would turn red. The problem stemmed from this code turning the tile red wouldn't occur when someone won due to the if-else structure of this part of the code. As such, manually setting the tile to red when displaying the victory screen resolves this issue.