Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: avatar choosing button not user friendly #35

Open
syfds opened this issue Nov 14, 2020 · 1 comment
Open

Settings: avatar choosing button not user friendly #35

syfds opened this issue Nov 14, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@syfds
Copy link

syfds commented Nov 14, 2020

Describe the bug
In settings dialog there is a button to choose an user image. This button has no label and is not descriptive enough for the end user.

To Reproduce
Steps to reproduce the behavior:

  1. Start BattleShip application
  2. Click on 'Settings'
  3. Scroll down to 'User Image'
  4. Button has no label

Expected behavior
Button should be labeled with a description, for example 'Choose...' or 'Open an image...'.

Optional: The second dialog with title 'Image Chooser' is redundant and should be removed.
Optional: Choosen image is scaled and showed between label 'User Image' and the button

Screenshots
image_2020-11-14_194416

Desktop (please complete the following information):

  • OS: [Elementary OS/Ubuntu]
  • Java Version: 14
  • Software Version: [v.0.0.1]
@syfds syfds added the bug Something isn't working label Nov 14, 2020
@Sokom141 Sokom141 added this to the 1.0 milestone Nov 14, 2020
@Sokom141
Copy link
Owner

Thank you @syfds for taking the time to contribute.

The first bug, which prevented you from seeing the avatar the first time you start the game (and also play the game #16 ), should be fixed in the develop branch that once merged with the main one will give birth to the 1.0 release.

I agree with you, it's not clear what the user should do and the image chooser frame is redundant, this is for sure something to address for the 1.0 milestone.
An important point it's also that all images should be resized to 32px*32px - #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants