Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getDefaultSession to retrieve an authenticated session #46

Open
phochste opened this issue Jul 13, 2022 · 0 comments
Open

Use getDefaultSession to retrieve an authenticated session #46

phochste opened this issue Jul 13, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@phochste
Copy link

phochste commented Jul 13, 2022

The current authSession is using the deprecated getClientAuthenticationWithDependencies to retrieve the authenticated session for a client.

https://github.com/SolidOS/solid-logic/blob/main/src/authSession/authSession.ts#L6

Using this technique to retrieve a session object will make it hard for external applications, to integrate solid-logic, solid-ui.

It would be better to assume that the application environment could already have created a logged-in session by some external logic. Solid-logic should be able to piggy-back on that external login flow.

Using getDefaultSession could be an integration method.

@timea-solid timea-solid added the enhancement New feature or request label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants