Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce that solo5_{block,net}_acquire() may only be called once #406

Open
mato opened this issue Sep 18, 2019 · 1 comment
Open

Enforce that solo5_{block,net}_acquire() may only be called once #406

mato opened this issue Sep 18, 2019 · 1 comment

Comments

@mato
Copy link
Member

mato commented Sep 18, 2019

(...)

Having said that, I can see how _acquire_ implies a transition of some kind, so perhaps it'd be better to just change the docs (solo5.h) to say that you're only allowed to call it once per handle?

Originally posted by @mato in #402

@mato
Copy link
Member Author

mato commented Sep 18, 2019

This is partially addressed by documenting the intended behaviour in solo5.h in #407. Actually enforcing this for hvt and spt is surprisingly hard due to the bindings-owned manifest structures being read-only, so leaving this open for dealing with in a future iteration/re-evaluation of how the manifest structures are dealt with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant