Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getKeys doesn't delimit String values #141

Open
dbeacham opened this issue Nov 28, 2022 · 0 comments
Open

getKeys doesn't delimit String values #141

dbeacham opened this issue Nov 28, 2022 · 0 comments

Comments

@dbeacham
Copy link

getKeys outputs the same value for Data.Aeson.String "null" and Data.Aeson.Null.

λ> getKeys V1 (sl "nullString" ("null" :: String))
["nullString:null"]

λ> getKeys V1 (sl "nullValue" (Nothing :: Maybe ()))
["nullValue:null"]

Same for Boolean values.

I can write my own version but might be a good idea to provide a version that supplies a delimiter? Could get the current version to do that but would be a breaking change.

I'm happy to supply a PR if this seems reasonable (and I haven't missed something obvious that already does this).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant