Skip to content

Commit 84aeebf

Browse files
committed
remove redundant stub constants
1 parent fbc7fe7 commit 84aeebf

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

spec/shared_examples/user_magic_login_shared_examples.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,8 @@
3333

3434
it do
3535
test_mailer_class = Class.new # need a mailer class to test
36-
stub_const('TestMailerClass', test_mailer_class)
37-
sorcery_model_property_set(:magic_login_mailer_class, TestMailerClass)
38-
expect(config.magic_login_mailer_class).to eq TestMailerClass
36+
sorcery_model_property_set(:magic_login_mailer_class, test_mailer_class)
37+
expect(config.magic_login_mailer_class).to eq test_mailer_class
3938
end
4039

4140
it do

spec/shared_examples/user_shared_examples.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,17 +184,17 @@
184184

185185
it 'subclass inherits config if defined so' do
186186
sorcery_reload!([], subclasses_inherit_config: true)
187-
stub_const('Admin', Class.new(User))
187+
admin = Class.new(User)
188188

189-
expect(Admin.sorcery_config).not_to be_nil
190-
expect(Admin.sorcery_config).to eq User.sorcery_config
189+
expect(admin.sorcery_config).not_to be_nil
190+
expect(admin.sorcery_config).to eq User.sorcery_config
191191
end
192192

193193
it 'subclass does not inherit config if not defined so' do
194194
sorcery_reload!([], subclasses_inherit_config: false)
195-
stub_const('Admin2', Class.new(User))
195+
admin2 = Class.new(User)
196196

197-
expect(Admin2.sorcery_config).to be_nil
197+
expect(admin2.sorcery_config).to be_nil
198198
end
199199
end
200200

@@ -395,9 +395,9 @@ def self.matches?(crypted, *tokens)
395395
crypted == encrypt(*tokens)
396396
end
397397
end
398-
stub_const('MyCrypto', my_crypto)
398+
399399
sorcery_model_property_set(:encryption_algorithm, :custom)
400-
sorcery_model_property_set(:custom_encryption_provider, MyCrypto)
400+
sorcery_model_property_set(:custom_encryption_provider, my_crypto)
401401

402402
username = user.send(User.sorcery_config.username_attribute_names.first)
403403

0 commit comments

Comments
 (0)