Remove Lint/ConstantDefinitionInBlock exclusion for specs

The RSpec-recommended way to temporarily define constants with stub_const

Author: beengine

.rubocop.yml

@@ -59,6 +59,3 @@ Style/Documentation:
   Exclude:
     - 'lib/**/*'
     - 'spec/**/*'
-Lint/ConstantDefinitionInBlock:
-  Exclude:
-    - 'spec/**/*'

spec/shared_examples/user_magic_login_shared_examples.rb

@@ -32,7 +32,8 @@
       end
 
       it do
-        TestMailerClass = Class.new # need a mailer class to test
+        test_mailer_class = Class.new # need a mailer class to test
+        stub_const('TestMailerClass', test_mailer_class)
         sorcery_model_property_set(:magic_login_mailer_class, TestMailerClass)
         expect(config.magic_login_mailer_class).to eq TestMailerClass
       end

spec/shared_examples/user_shared_examples.rb

@@ -184,15 +184,15 @@
 
     it 'subclass inherits config if defined so' do
       sorcery_reload!([], subclasses_inherit_config: true)
-      class Admin < User; end
+      stub_const('Admin', Class.new(User))
 
       expect(Admin.sorcery_config).not_to be_nil
       expect(Admin.sorcery_config).to eq User.sorcery_config
     end
 
     it 'subclass does not inherit config if not defined so' do
       sorcery_reload!([], subclasses_inherit_config: false)
-      class Admin2 < User; end
+      stub_const('Admin2', Class.new(User))
 
       expect(Admin2.sorcery_config).to be_nil
     end
@@ -386,7 +386,7 @@ class Admin2 < User; end
     end
 
     it 'works with custom password encryption' do
-      class MyCrypto
+      my_crypto = Class.new do
         def self.encrypt(*tokens)
           tokens.join.tr('e', 'A')
         end
@@ -395,6 +395,7 @@ def self.matches?(crypted, *tokens)
           crypted == encrypt(*tokens)
         end
       end
+      stub_const('MyCrypto', my_crypto)
       sorcery_model_property_set(:encryption_algorithm, :custom)
       sorcery_model_property_set(:custom_encryption_provider, MyCrypto)