Updated Spectogram.py #82
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @Shubhanshu-356! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
|
Check it once it has no branch conflicts now I have fixed it. |
|
Check my pull request as I have checked the branching conflicts there is no branching conflicts. Review my changes if possible. |
It still shows me conflicts. Please fix it. |
|
Ok I will fix it and update these as soon as possible. |
|
Can you please check once. Shall it again showing the same. |
Spectogram.py
Outdated
| import subprocess | ||
|
|
||
|
|
||
| main |
There was a problem hiding this comment.
could you remove branch names mentioned across the file for "main" and "gui-performance-enhancement"
There was a problem hiding this comment.
Means you are saying that I have to remove the branch name
Is it correct I am saying. What is the problem occuring by your side when you are merging. Can you please tell me
There was a problem hiding this comment.
yes, remove the branch names in the code file. I believe it might've occurred while solving a merge conflict
There was a problem hiding this comment.
Ok I will do thanks for the info
There was a problem hiding this comment.
Can you please check it now for merging
There was a problem hiding this comment.
could you remove branch names mentioned across the file for "main" and "gui-performance-enhancement"
I still see those!
|
Thank you |
|
But I have checked it's not there now any main |
|
can still see the branches names mentioned in the file could you remove them and then request for merge @Shubhanshu-356 |
|
Now can you check I have removed all |
| if __name__ == "__main__": | ||
| main() | ||
|
|
||
| def close_current_visualizer(): | ||
| if _VARS["current_visualizer_process"] and _VARS["current_visualizer_process"].poll() is None: |
There was a problem hiding this comment.
block of code here is missing indentation
PR Description
I have updated the gui responsiveness of Spectogram Application by adding the multithreading, Optimized Plotting and buffering features in it.
Related Issues
Closes #66
Checklist
Undertaking
I declare that:
The content I am submitting is original and has not been plagiarized.
No portion of the work has been copied from any other source without proper attribution.
The work has been checked for plagiarism, and I assure its authenticity.
I understand that any violation of this undertaking may have legal consequences that I will bear and could result in the withdrawal of any recognition associated with the work.
I Agree