Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]Adding Modularity and Refactoring #78

Open
manmita opened this issue May 19, 2024 · 1 comment
Open

[feature]Adding Modularity and Refactoring #78

manmita opened this issue May 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request gssoc level1

Comments

@manmita
Copy link

manmita commented May 19, 2024

Is your feature request related to a problem? Please describe.
The project lacks proper code structure and there is a lot of code redundancy.

Describe the solution you'd like
I would like to create a design for the code such that functions like draw() are reused which will allow users to use these functions and build up on it. Also adding a file structure will help users to navigate easily.

Proposed file structure
a) src:
--->1) main.py - which calls the 3 audio visualizers based on user input
--->2) util - containing draw.py and other utils
--->3) visualizers - which contain the main code (importing the utils required)
b) documentation
c) guidelines

Additional context
I would like to contribute these changes to the main project. Please assign me this issue @Soumya-Kushwaha

Copy link

Congratulations, @manmita! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc level1
Projects
None yet
Development

No branches or pull requests

2 participants