Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save and recall PID settings #3

Closed
joshua255 opened this issue Jul 8, 2019 · 6 comments
Closed

save and recall PID settings #3

joshua255 opened this issue Jul 8, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@joshua255
Copy link
Member

Being able to save and recall one set of PID constants to a file is important so the robot doesn't have to be retuned every time it is used. It would be even better if it can store different values for each robot and each configuration, and even cooler if these values could be synced between driverstations so we can switch robots and not have to retune (that could be a file manually copied between devices). Or, if you would prefer, we could try to have the robot store its PID values to its flash/eeprom memory, and transmit them to the driverstation on startup.

@joshua255 joshua255 added the enhancement New feature or request label Jul 8, 2019
@andrewda
Copy link
Member

andrewda commented Jul 8, 2019

I take it it wouldn't be easy to do this robot-side? Because this means your have to retune the PID for every device that wants to drive the robot, and that seems unfriendly/unintuitive at best.

Edit: sorry I didn't read your whole post before commenting haha. I think it'd be best to just save the last PID settings in the robot's flash memory?

@joshua255
Copy link
Member Author

I don't think it would be too bad to do it robot side, can I try that first?

@joshua255
Copy link
Member Author

I'll update this issue with a description of how the robot sends recalled values, when I think of how.

@andrewda
Copy link
Member

andrewda commented Jul 8, 2019

@joshua255 Maybe we could have the ds send an initial "hello" message to the robot (potentially with some special data, e.g. ip address or something like that), and the robot responds with its own "hello" message, containing PID values and other recalled constants.

@joshua255
Copy link
Member Author

Would you mind having a save settings on robot button?

@andrewda
Copy link
Member

done in v2, 4 years late! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants