We are more than happy to accept external contributions to the project in the form of feedback, bug reports and even better - pull requests :) At this time we are primarily focusing on improving the user-experience and stability of Penny4NASA for our first release. Please keep this in mind if submitting feature requests, which we're happy to consider for future versions.
This project uses single-quotes, two space indentation, multiple var statements and whitespace around arguments. Use a single space after keywords like function
. Ex:
function () { ... }
function foo() { ... }
Please ensure any pull requests follow this closely. If you notice existing code which doesn't follow these practices, feel free to shout and we will address this.
- Please check to make sure that there aren't existing pull requests attempting to address the issue mentioned. We also recommend checking for issues related to the issue on the tracker, as a team member may be working on the issue in a branch or fork.
- Non-trivial changes should be discussed in an issue first
- Develop in a topic branch, not master
- Lint the code by running
grunt
- Add relevant tests to cover the change
- Make sure test-suite passes:
npm test
- Squash your commits
- Write a convincing description of your PR and why we should land it