return in finally swallows exceptions

[iritkatriel]

In the following places:

mail-parser/src/mailparser/mailparser.py

Line 650 in 77fe015

return conv

mail-parser/src/mailparser/mailparser.py

Line 663 in 77fe015

return timezone

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, it will not propagate on as expected.

If the intention is to suppress all exceptions, I would propose to make this clear by using "except BaseException".

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.

[fedelemantuano]

Thanks for your contribution.
Fixed in PR #125