Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve probes for akv2k8s #97

Closed
slushysnowman opened this issue Mar 10, 2023 · 2 comments
Closed

Improve probes for akv2k8s #97

slushysnowman opened this issue Mar 10, 2023 · 2 comments

Comments

@slushysnowman
Copy link

In akv2k8s:

  • Controller has no probes configured
  • Injector only has a readiness probe configured

It would be good if these both had both sorts of probes so that:

  • Pods get restarted if they encounter errors
  • Compliance requirements can be met (some clusters require probes)
@KenADev
Copy link
Contributor

KenADev commented Jun 10, 2023

The probes are apparently dependent of the prometheus metrics endpoints, causing the controller probes to fail when global.metrics.enabled is set to false, which is currently the default in values.yaml

$ kubectl describe pod/akv2k8s-controller-77dbc456bd-k5n5b
Events:
  Type     Reason     Age                  From               Message
  ----     ------     ----                 ----               -------
  Normal   Scheduled  118s                 default-scheduler  Successfully assigned akv2k8s/akv2k8s-controller-77dbc456bd-k5n5b to aks-nodepool1-60850117-vmss000000
  Normal   Pulled     88s (x2 over 118s)   kubelet            Container image "spvest/azure-keyvault-controller:1.4.0" already present on machine
  Normal   Created    88s (x2 over 118s)   kubelet            Created container controller
  Normal   Started    88s (x2 over 118s)   kubelet            Started container controller
  Normal   Killing    88s                  kubelet            Container controller failed liveness probe, will be restarted
  Warning  Unhealthy  68s (x12 over 117s)  kubelet            Readiness probe failed: Get "http://10.244.0.29:9000/healthz": dial tcp 10.244.0.29:9000: connect: connection refused
  Warning  Unhealthy  58s (x6 over 108s)   kubelet            Liveness probe failed: Get "http://10.244.0.29:9000/healthz": dial tcp 10.244.0.29:9000: connect: connection refused

Edit: See also #105

@181192
Copy link
Collaborator

181192 commented Nov 12, 2023

@181192 181192 closed this as completed Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants