Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: MapAddress Navigation Command not Working #45

Open
2 tasks done
mikedotmundy opened this issue Nov 4, 2024 · 2 comments
Open
2 tasks done

[Issue]: MapAddress Navigation Command not Working #45

mikedotmundy opened this issue Nov 4, 2024 · 2 comments
Labels
bug Something isn't working Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.

Comments

@mikedotmundy
Copy link

mikedotmundy commented Nov 4, 2024

Describe the Issue in Detail

Consider the following code:

<StackLayout.GestureRecognizers>
     <TapGestureRecognizer Command="{Binding MapAddress}"
          CommandParameter="{Rock:MapAddressParameters Name='Spark' Address='24654 N Lake Pleasant Pkwy, Suite 103-192, Peoria, AZ 85383'}" />
</StackLayout.GestureRecognizers>

In this scenario, tapping on the StackLayout should navigate you to the device's native map application. Instead, an error message is displayed.

In the Orange and Blue apps, both running v6.0.0.0:
Screenshot 2024-11-04 at 14 55 22

In our church app, also running v6.0.0.0:
Screenshot 2024-11-04 at 14 55 38

Removing the Address='...' section from the code above removes the error, but then it does not function properly.

Can reproduce in

  • Orange App
  • Blue App

Steps to Reproduce

See steps above

Expected Behavior

MapAddress Command should work.

Actual Behavior

MapAddress Command does not work.

Screenshots or Videos

See above

Reproduction XAML

No response

Mobile Shell Version

v6.0.0.0

Last Known Working Version

Unknown

iOS Device Type(s) and iOS Version(s)

iPhone 15 Pro Max, iOS 18.0.1

Android Device Type(s) and Android Version(s)

Did not test

@mikedotmundy mikedotmundy added bug Something isn't working unverified This issue has not been verified yet labels Nov 4, 2024
@Panha-Sim
Copy link

Hello Mike,

We've confirmed and are investigating the issue. In the meantime, you can achieve the same result by writing out the command parameter in a "long-hand" way, as opposed to inline:

<Button StyleClass="btn, btn-primary" Text="Map" Command="{Binding MapAddress}" >
  <Button.CommandParameter>
    <Rock:MapAddressParameters Name="Spark" Address="24654 N Lake Pleasant Pkwy, Suite 103-192, Peoria, AZ 85383" />
  </Button.CommandParameter>
</Button>

@bradencohen bradencohen added Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be. and removed unverified This issue has not been verified yet labels Nov 5, 2024
@mikedotmundy
Copy link
Author

Thank you @Panha-Sim! I have it working the "long-hand" way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Status: Confirmed It's clear what the subject of the issue is about, and what the resolution should be.
Projects
None yet
Development

No branches or pull requests

3 participants