Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] esbuild clarification #134

Open
merojosa opened this issue Aug 11, 2023 · 2 comments
Open

[REQUEST] esbuild clarification #134

merojosa opened this issue Aug 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@merojosa
Copy link

What would you like to have implemented?

Hello there!

I've been using this great package with Heroku and I tried to bundle my Node.js app with TypeScript using esbuild. However, I encountered a bug that said Error The input directory "/app/bin" does not exist..

I already fixed that error by adding to my build script the flag --packages=external (didn't know that was recommended by the esbuild documentation). Therefore, this is the build script that I have that works with this package:

"build": "esbuild src/index.ts --bundle --platform=node --packages=external --target=node18 --outdir=dist"

I'm wondering if it's possible to add a clarification in the documentation in case some else encounters this same bug. The only issue that I can think of is that I'm not entirely sure if the problem that I had was exclusively to Heroku or not. So probably some research needs to be done with at least a couple of different services to check if the problem persists.

If you think this makes any sense, I'm willing to research about it and, if the same problem is anywhere else, I can create PR with the clarification.

Let me know if this makes any sense.

Why would it be useful?

It will help the people who will use esbuild to bundle their Node.js app.

@merojosa merojosa added the enhancement New feature or request label Aug 11, 2023
@Sparticuz
Copy link
Owner

Sure, go ahead and send in a PR. I think external is also needed for webpack configs.

@harithzainudin
Copy link

yup. im using esbuild also. and this will surely help a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants