Merge branch 'development'

SpeciesFileGroup · Jun 12, 2020 · 11db6e6 · 11db6e6
2 parents 1ecf8f8 + b04fc33
commit 11db6e6
Show file tree

Hide file tree

Showing 30 changed files with 2,300 additions and 3,632 deletions.
diff --git a/.browserslistrc b/.browserslistrc
@@ -1 +1 @@
-> 1%
+defaults
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,209 @@
+# Changelog
+
+All (hopefully) notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+This project <em>does not yet</em> adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html) as the API is evolving and MINOR patches may be backwards incompatible.
+
+## [unreleased]
+
+\-
+
+## [0.12.6] - 2020-06-12
+### Added
+- CHANGELOG.md
+- Matrix observation filters
+- Full backtrace in exception notification
+- `count` and several other basic default units to Descriptors [#1501]
+- Basic Observation::Continuous operators
+- Linked new Descriptor form to Task - New descriptor
+
+### Changed
+- Updated node packages and changed webpacker configuration
+- Progress on fix for [#1420]: CoLDP - Name element columns only getting populated for not valid names
+- Made TaxonNameClassification scopes more specific to allow citation ordering (refs [#1040])
+
+### Fixed
+- Minor fix in observation matrix dashboard
+- Potential fix for `PG::TRDeadlockDetected` when updating taxon name-related data
+
+[#1420]: https://github.com/SpeciesFileGroup/taxonworks/issues/1420
+[#1040]: https://github.com/SpeciesFileGroup/taxonworks/issues/1040
+[#1501]: https://github.com/SpeciesFileGroup/taxonworks/issues/1501
+
+## [0.12.5] - 2020-06-08
+### Added
+- Default unit selector for sample character in New Descriptor task ([#1533])
+- 'None' option for unit selector in Matrix Row Encoder task
+- New Descriptor units
+
+### Changed
+- Updated websocket-extensions node package
+- Optimized smart selector refresh
+- Improved removal error message when source is still in use by some project
+
+### Fixed
+- Language selector backend bug
+- Sort by page on Citations by Source task ([#1536])
+- Removed duplicate `destroy` on project sources controller
+
+[#1533]: https://github.com/SpeciesFileGroup/taxonworks/issues/1533
+[#1536]: https://github.com/SpeciesFileGroup/taxonworks/issues/1536
+
+## [0.12.4] - 2020-06-05
+### Added
+- Pagination on New Observation Matrix task
+- Hyperlink to Observation Matrices Dashboard task on New Observation Matrix task (#1532)
+- New deletion warning messages on New Observation Matrix task
+
+### Changed
+- Renamed New Matrix task to New Observation Matrix
+- Citations are now saved without locking on New Taxon Name task
+- Updated gems (`bundle update` without altering `Gemfile`)
+- Several optimizations on recently used objects retrieval for smart selectors
+
+### Fixed
+- Loosing input page numbers when switching tabs on New Taxon Name task
+
+[#1532]: https://github.com/SpeciesFileGroup/taxonworks/issues/1532
+
+[unreleased]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.5...development
+[0.12.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.5...v0.12.6
+[0.12.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.4...v0.12.5
+[0.12.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.3...v0.12.4
+
+----
+The following versions predate this CHANGELOG. You may check the comparison reports generated by GitHub by clicking the versions below
+
+|<!-- -->|<!-- -->|
+|---|---|
+|0.12.x|[0.12.3] (2020-06-04) [0.12.2] (2020-06-02) [0.12.1] (2020-05-29) [0.12.0] (2020-05-15)|
+|0.11.x|[0.11.0] (2020-04-17)|
+|0.10.x|[0.10.9] (2020-04-03) [0.10.8] (2020-03-27) [0.10.7] (2020-03-26) [0.10.6] (2020-03-18) [0.10.5] (2020-03-11) [0.10.4] (2020-03-04) [0.10.3] (2020-02-25) [0.10.2] (2020-02-22) [0.10.1] (2020-02-21) [0.10.0] (2020-02-20)|
+|0.9.x|[0.9.8] (2020-02-05) [0.9.7] (2020-02-03) [0.9.6] (2020-01-29) [0.9.5] (2020-01-14) [0.9.4] (2020-01-10) [0.9.3] (2019-12-23) [0.9.2] (2019-12-18) [0.9.1] (2019-12-16) [0.9.0] (2019-12-13)|
+|0.8.x|[0.8.9] (2019-12-11) [0.8.8] (2019-12-09) [0.8.7] (2019-12-06) [0.8.6] (2019-12-06) [0.8.5] (2019-11-27) [0.8.4] (2019-11-26) [0.8.3] (2019-11-22) [0.8.2] (2019-11-21) [0.8.1] (2019-11-19) [0.8.0] (2019-11-16)|
+|0.7.x|[0.7.4] (2019-10-23) [0.7.3] (2019-10-19) [0.7.2] (2019-10-05) [0.7.1] (2019-10-02) [0.7.0] (2019-09-30)|
+|0.6.x|[0.6.1] (2019-06-16) [0.6.0] (2019-06-14)|
+|0.5.x|[0.5.4] (2019-05-02) [0.5.3] (2019-05-02) [0.5.2] (2019-04-23) [0.5.1] (2019-04-18) [0.5.0] (2019-04-10)|
+|0.4.x|[0.4.5] (2018-12-14) [0.4.4] (2018-12-06) [0.4.3] (2018-12-04) [0.4.2] (2018-12-04) [0.4.1] (2018-11-28) [0.4.0] (2018-11-08)|
+|0.3.x (\*)|[0.3.16] (2018-09-24) [0.3.15] (2018-09-17) [0.3.14] (2018-09-11) [0.3.13] (2018-09-11) [0.3.12] (2018-05-14) [0.3.11] (2018-05-11) [0.3.9] (2018-05-11) [0.3.7] (2018-05-10) [0.3.6] (2018-05-10) [0.3.4] (2018-05-02) [0.3.3] (2018-05-02) [0.3.2] (2018-03-27) [0.3.1] (2018-03-08) [0.3.0] (2018-03-08)|
+|0.2.x (\*)|[0.2.29] (2018-02-05) [0.2.28] (2017-07-19) [0.2.27] (2017-07-19) [0.2.26] (2017-07-16) [0.2.25] (2017-07-12) [0.2.24] (2017-07-12) [0.2.23] (2017-07-11) [0.2.22] (2017-07-11) [0.2.21] (2017-07-10) [0.2.20] (2017-07-10) [0.2.19] (2017-07-10) [0.2.18] (2017-07-10) [0.2.17] (2017-07-10) [0.2.15] (2017-07-10) [0.2.11] (2017-07-10) [0.2.10] (2017-07-10) [0.2.9] (2017-07-10) [0.2.8] (2017-07-10) [0.2.6] (2017-07-10) [0.2.5] (2017-07-10) [0.2.4] (2017-07-10) [0.2.3] (2017-07-10) [0.2.2] (2017-07-10) [0.2.1] (2017-07-10) [0.2.0] (2017-07-10)|
+|0.1.x|*Unreleased*|
+|0.0.x|[0.0.10] (2017-06-23) [0.0.9] (2017-06-23) [0.0.8] (2017-06-09) [0.0.6] (2017-06-09) [0.0.5] (2017-06-09) [0.0.4] (2017-06-09) [0.0.3] (2017-06-02) [0.0.2] (2017-06-01) 0.0.1(\*\*) (2017-06-01)|
+
+*(\*) Missing versions have not been released.*
+
+*(\*\*) Report cannot be provided as this is the first release.*
+
+[0.12.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.2...v0.12.3
+[0.12.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.1...v0.12.2
+[0.12.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.12.0...v0.12.1
+[0.12.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.11.0...v0.12.0
+
+
+[0.11.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.9...v0.11.0
+
+[0.10.9]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.8...v0.10.9
+[0.10.8]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.7...v0.10.8
+[0.10.7]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.6...v0.10.7
+[0.10.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.5...v0.10.6
+[0.10.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.4...v0.10.5
+[0.10.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.3...v0.10.4
+[0.10.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.2...v0.10.3
+[0.10.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.1...v0.10.2
+[0.10.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.10.0...v0.10.1
+[0.10.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.8...v0.10.0
+
+[0.9.8]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.7...v0.9.8
+[0.9.7]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.6...v0.9.7
+[0.9.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.5...v0.9.6
+[0.9.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.4...v0.9.5
+[0.9.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.3...v0.9.4
+[0.9.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.2...v0.9.3
+[0.9.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.1...v0.9.2
+[0.9.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.9.0...v0.9.1
+[0.9.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.8...v0.9.0
+
+[0.8.9]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.8...v0.8.9
+[0.8.8]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.7...v0.8.8
+[0.8.7]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.6...v0.8.7
+[0.8.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.5...v0.8.6
+[0.8.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.4...v0.8.5
+[0.8.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.3...v0.8.4
+[0.8.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.2...v0.8.3
+[0.8.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.1...v0.8.2
+[0.8.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.8.0...v0.8.1
+[0.8.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.7.3...v0.8.0
+
+[0.7.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.7.3...v0.7.4
+[0.7.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.7.2...v0.7.3
+[0.7.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.7.1...v0.7.2
+[0.7.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.7.0...v0.7.1
+[0.7.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.6.1...v0.7.0
+
+[0.6.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.6.0...v0.6.1
+[0.6.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.5.4...v0.6.0
+
+[0.5.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.5.3...v0.5.4
+[0.5.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.5.2...v0.5.3
+[0.5.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.5.1...v0.5.2
+[0.5.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.5.0...v0.5.1
+[0.5.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.5...v0.5.0
+
+[0.4.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.4...v0.4.5
+[0.4.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.3...v0.4.4
+[0.4.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.2...v0.4.3
+[0.4.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.1...v0.4.2
+[0.4.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.4.0...v0.4.1
+[0.4.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.16...v0.4.0
+
+[0.3.16]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.15...v0.3.16
+[0.3.15]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.14...v0.3.15
+[0.3.14]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.13...v0.3.14
+[0.3.13]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.12...v0.3.13
+[0.3.12]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.11...v0.3.12
+[0.3.11]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.9...v0.3.11
+[0.3.9]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.7...v0.3.9
+[0.3.7]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.6...v0.3.7
+[0.3.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.4...v0.3.6
+[0.3.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.3...v0.3.4
+[0.3.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.2...v0.3.3
+[0.3.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.1...v0.3.2
+[0.3.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.3.0...v0.3.1
+[0.3.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.29...v0.3.0
+
+[0.2.29]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.28...v0.2.29
+[0.2.28]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.27...v0.2.28
+[0.2.27]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.26...v0.2.27
+[0.2.26]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.25...v0.2.26
+[0.2.25]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.24...v0.2.25
+[0.2.24]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.23...v0.2.24
+[0.2.23]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.22...v0.2.23
+[0.2.22]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.21...v0.2.22
+[0.2.21]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.20...v0.2.21
+[0.2.20]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.19...v0.2.20
+[0.2.19]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.18...v0.2.19
+[0.2.18]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.17...v0.2.18
+[0.2.17]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.15...v0.2.17
+[0.2.15]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.11...v0.2.15
+[0.2.11]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.10...v0.2.11
+[0.2.10]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.9...v0.2.10
+[0.2.9]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.8...v0.2.9
+[0.2.8]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.6...v0.2.8
+[0.2.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.5...v0.2.6
+[0.2.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.4...v0.2.5
+[0.2.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.3...v0.2.4
+[0.2.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.2...v0.2.3
+[0.2.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.1...v0.2.2
+[0.2.1]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.2.0...v0.2.1
+[0.2.0]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.10...v0.2.0
+
+[0.0.10]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.9...v0.0.10
+[0.0.9]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.8...v0.0.9
+[0.0.8]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.7...v0.0.8
+[0.0.7]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.6...v0.0.7
+[0.0.6]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.5...v0.0.6
+[0.0.5]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.4...v0.0.5
+[0.0.4]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.3...v0.0.4
+[0.0.3]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.2...v0.0.3
+[0.0.2]: https://github.com/SpeciesFileGroup/taxonworks/compare/v0.0.1...v0.0.2
diff --git a/app/controllers/crash_test_controller.rb b/app/controllers/crash_test_controller.rb
@@ -1,7 +1,7 @@
 class CrashTestController < ApplicationController
 
   def index
-    1 / 0
+    User.create!
   end
 
 end
diff --git a/app/javascript/packs/application.js b/app/javascript/packs/application.js
@@ -7,6 +7,8 @@
 // To reference this file, add <%= javascript_pack_tag 'application' %> to the appropriate
 // layout file, like app/views/layouts/application.html.erb
 
+import 'core-js/stable'
+import 'regenerator-runtime/runtime'
 // Styles
 require('../style/application.scss')
 require('leaflet/dist/leaflet.css')
@@ -57,4 +59,4 @@ require('../vue/tasks/biological_relationships/composer/main.js')
 require('../vue/tasks/nomenclature/match/main.js')
 require('../vue/tasks/controlled_vocabularies/manage/main.js')
 require('../vue/tasks/collection_objects/match/main.js')
-require('../vue/tasks/sources/filter/main.js')
+require('../vue/tasks/sources/filter/main.js')
diff --git a/app/javascript/vue/tasks/digitize/components/taxonDetermination/main.vue b/app/javascript/vue/tasks/digitize/components/taxonDetermination/main.vue
@@ -97,7 +97,9 @@
         id="determination-add-button"
         :disabled="!otuId"
         class="button normal-input button-submit separate-top"
-        @click="addDetermination">Add</button>
+        @click="addDetermination">
+        {{ taxonDetermination.id ? 'Set' : 'Add' }}
+      </button>
       <draggable
         class="table-entrys-list"
         element="ul"
@@ -108,11 +110,16 @@
           v-for="(item, index) in list">
           <span v-html="item.object_tag"/>
           <div class="horizontal-left-content">
+            <span
+              v-if="item.id"
+              @click="editTaxonDetermination(item)"
+              class="button circle-button btn-edit"/>
             <radial-annotator
               v-if="item.hasOwnProperty('global_id')"
               :global-id="item.global_id"/>
             <span
               class="circle-button btn-delete"
+              :class="{ 'button-default': !item.id }"
               @click="removeTaxonDetermination(item)"/>
           </div>
         </li>
@@ -149,8 +156,13 @@ export default {
     collectionObject() {
       return this.$store.getters[GetterNames.GetCollectionObject]
     },
-    taxonDetermination() {
-      return this.$store.getters[GetterNames.GetTaxonDetermination]
+    taxonDetermination: {
+      get () {
+        return this.$store.getters[GetterNames.GetTaxonDetermination]
+      },
+      set (value) {
+        this.$store.commit(MutationNames.SetTaxonDetermination, value)
+      }
     },
     otu: {
       get() {
@@ -210,7 +222,7 @@ export default {
     },
     list: {
       get () {
-      return this.$store.getters[GetterNames.GetTaxonDeterminations]
+        return this.$store.getters[GetterNames.GetTaxonDeterminations]
       },
       set (value) {
         this.$store.commit(MutationNames.SetTaxonDeterminations, value)
@@ -285,11 +297,11 @@ export default {
       this.$store.dispatch(ActionNames.SaveDetermination)
     },
     addDetermination () {
-      if (this.list.find((determination) => {
+      if (!this.taxonDetermination.id && this.list.find((determination) => {
         return determination.otu_id === this.taxonDetermination.otu_id && (determination.year_made === this.year)
       })
       ) { return }
-      this.taxonDetermination.object_tag = `${this.otuSelected}`
+      this.taxonDetermination.object_tag = `${this.otuSelected} ${this.authorsString()} ${this.dateString()}`
       this.$store.commit(MutationNames.AddTaxonDetermination, this.taxonDetermination)
       this.$store.commit(MutationNames.NewTaxonDetermination)
     },
@@ -310,6 +322,27 @@ export default {
     setOtu (otu) {
       this.otuId = otu.id
       this.otuSelected = otu.object_tag
+    },
+    editTaxonDetermination (item) {
+      this.taxonDetermination = {
+        id: item.id,
+        global_id: item.global_id,
+        otu_id: item.otu_id,
+        day_made: item.day_made,
+        month_made: item.month_made,
+        year_made: item.year_made,
+        position: item.position,
+        roles_attributes: item.hasOwnProperty('determiner_roles') ? item.determiner_roles : item.roles_attributes
+      }
+    },
+    authorsString () {
+      return this.taxonDetermination.roles_attributes.length ? `by ${this.taxonDetermination.roles_attributes.map(item => item.hasOwnProperty('person') ? item.person.last_name : item.last_name).join(', ')}` : ''
+    },
+    dateString () {
+      if (this.taxonDetermination.day_made || this.taxonDetermination.month_made || this.taxonDetermination.year_made) {
+        return `on ${this.taxonDetermination.day_made ? `${this.taxonDetermination.day_made}-` : ''}${this.taxonDetermination.month_made ? `${this.taxonDetermination.month_made}-` : ''}${this.taxonDetermination.year_made ? `${this.taxonDetermination.year_made}` : ''}`
+      }
+      return ''
     }
   }
 }

diff --git a/app/javascript/vue/tasks/digitize/store/actions/saveDetermination.js b/app/javascript/vue/tasks/digitize/store/actions/saveDetermination.js
@@ -4,20 +4,15 @@ import ValidateDetermination from '../../validations/determination'
 import TaxonDetermination from '../../const/taxonDetermination'
 
 export default function ({ commit, state }, determination) {
-  function addToList(taxonDetermination) {
-    if(!state.taxon_determinations.find((item) => { return item.id == taxonDetermination.id})) {
-      commit(MutationNames.AddTaxonDetermination, taxonDetermination)
-    }    
-  }
   return new Promise((resolve, reject) => {
     let taxon_determination = determination
     taxon_determination.biological_collection_object_id = state.collection_object.id
 
     if(ValidateDetermination(taxon_determination)) {
       if(taxon_determination.id) {
         UpdateTaxonDetermination(taxon_determination).then(response => {
-          //commit(MutationNames.SetTaxonDetermination, response)
-          addToList(response.body)
+          state.collection_object.object_tag = response.body.collection_object.object_tag
+          commit(MutationNames.AddTaxonDetermination, response.body)
           resolve(response.body)
         }, (response) => {
           reject(response)
@@ -26,7 +21,7 @@ export default function ({ commit, state }, determination) {
       else {
         CreateTaxonDetermination(taxon_determination).then(response => {
           state.collection_object.object_tag = response.body.collection_object.object_tag
-          addToList(response.body)
+          commit(MutationNames.AddTaxonDetermination, response.body)
           resolve(response.body)
         }, (response) => {
           reject(response)