Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable for postgres database #141

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix environment variable for postgres database #141

merged 1 commit into from
Oct 13, 2023

Conversation

uidzeroo
Copy link
Contributor

@uidzeroo uidzeroo commented Oct 11, 2023

Description

In the current scripts a wrong environment variable is used for the postgres database and therefore the current variable has no influence on the name of the postgres database. When creating the postgres database, the default behavior of postgres is currently applied (username as database name).

Motivation and Context

The pull request simply replaces the incorrect variable POSTGRES_DATABASE with the correct POSTGRES_DB (See https://hub.docker.com/_/postgres) so that this functionality can be used correctly.

How Has This Been Tested?

A new container with a customized database name was created and verified within the container.

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@uidzeroo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! Especially appreciate taking the effort to clean related env var names to be more consistent with the correct env var as well

@superlinkx superlinkx merged commit 06d1e55 into SpecterOps:main Oct 13, 2023
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants