Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New role "Power User" #343

Merged
merged 8 commits into from
Jan 30, 2024
Merged

New role "Power User" #343

merged 8 commits into from
Jan 30, 2024

Conversation

elikmiller
Copy link
Collaborator

Description

This change introduces a new user role "Power User." This role has permissions beyond what a "User" has but can not view, modify, or delete other users, nor can it modify or delete SSO configurations.

Specifically, this role is assigned the following permissions.

GraphDBWrite
GraphDBRead
AppReadApplicationConfiguration
AppWriteApplicationConfiguration
CollectionManageJobs
ClientsManage
ClientsTasking
AuthCreateToken
AuthManageSelf
APsGenerateReport
APsManageAPs
SavedQueriesRead
SavedQueriesWrite
ClientsRead

Motivation and Context

This change provides an additional option for organizations interested in allowing specific users an elevated set of permissions without granting them full access to manage other users or SSO configurations.

How Has This Been Tested?

No new tests have been added - I would welcome some help here!

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@elikmiller elikmiller self-assigned this Jan 24, 2024
@mistahj67 mistahj67 force-pushed the BED-3995_power_user branch 6 times, most recently from 8aa0a5d to 88f7a26 Compare January 29, 2024 20:24
rvazarkar
rvazarkar reviewed Jan 29, 2024
View reviewed changes
cmd/api/src/api/v2/apiclient/auth.go Show resolved Hide resolved
cmd/api/src/api/v2/apiclient/savedqueries.go
func (s Client) CreateSavedQuery() (model.SavedQuery, error) {
var query model.SavedQuery
payload := v2.CreateSavedQueryRequest{
Query: "Match(q:Question {life: 1, universe: 1, everything: 1}) return q",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@mistahj67 mistahj67 force-pushed the BED-3995_power_user branch 5 times, most recently from 4e20a5e to 09d8e8c Compare January 30, 2024 15:22
@mistahj67 mistahj67 force-pushed the BED-3995_power_user branch from 09d8e8c to 205b0d4 Compare January 30, 2024 20:42
@mistahj67 mistahj67 requested review from rvazarkar and ddlees January 30, 2024 20:58
@mistahj67 mistahj67 merged commit b364762 into main Jan 30, 2024
3 checks passed
@mistahj67 mistahj67 deleted the BED-3995_power_user branch January 30, 2024 21:25
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ddlees ddlees ddlees approved these changes

@rvazarkar rvazarkar Awaiting requested review from rvazarkar

Assignees

@elikmiller elikmiller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elikmiller @rvazarkar @ddlees @mistahj67