-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bed 4069 #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irshadaj
reviewed
Feb 2, 2024
irshadaj
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, lgtm
computator
requested changes
Feb 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall, but I added some feedback on the implementation
computator
approved these changes
Feb 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds
Partially Completed
status for analysis to reflect when parts of analysis fail and others do not. This means that analysis can complete 1 of 3 ways:Complete
- All of analysis completes successfullyPartially Complete
- Some parts of analysis failed, however at least one was successful.Failed
- All parts of analysis failed.Motivation and Context
When customers go to see the status of collection and analysis, they are only advised
Complete
orFailed
. This is based on the complete analysis finishing without any warnings or errors. Because some of analysis can fail but some data is still processed, a status of Partially Completed with additional logging should help trouble shoot the problem.How Has This Been Tested?
Manual testing errors happening at each step of analysis independently and collectively.
Types of changes
Checklist: