Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bed 4069 #383

Merged
merged 15 commits into from
Feb 5, 2024
Merged

Bed 4069 #383

merged 15 commits into from
Feb 5, 2024

Conversation

benwaples
Copy link
Contributor

@benwaples benwaples commented Feb 2, 2024

Description

Adds Partially Completed status for analysis to reflect when parts of analysis fail and others do not. This means that analysis can complete 1 of 3 ways:

  1. Complete - All of analysis completes successfully
  2. Partially Complete - Some parts of analysis failed, however at least one was successful.
  3. Failed - All parts of analysis failed.

Motivation and Context

When customers go to see the status of collection and analysis, they are only advised Complete or Failed. This is based on the complete analysis finishing without any warnings or errors. Because some of analysis can fail but some data is still processed, a status of Partially Completed with additional logging should help trouble shoot the problem.

How Has This Been Tested?

Manual testing errors happening at each step of analysis independently and collectively.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@benwaples benwaples self-assigned this Feb 2, 2024
@benwaples benwaples marked this pull request as ready for review February 2, 2024 17:39
Copy link
Contributor

@irshadaj irshadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, lgtm

Copy link
Member

@computator computator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, but I added some feedback on the implementation

cmd/api/src/daemons/datapipe/jobs.go Outdated Show resolved Hide resolved
cmd/api/src/daemons/datapipe/analysis.go Outdated Show resolved Hide resolved
@benwaples benwaples merged commit d1e07b9 into main Feb 5, 2024
3 checks passed
@benwaples benwaples deleted the BED-4069 branch February 5, 2024 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants