Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create usePermissions UI hook #413

Merged
merged 20 commits into from
Mar 8, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
546c222
move types and run license check
maffkipp Feb 12, 2024
084b73b
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 14, 2024
5d16e3c
pulling in most recent main
maffkipp Feb 14, 2024
d69b6e4
added useAppSelector
maffkipp Feb 14, 2024
d714999
ran license check
maffkipp Feb 14, 2024
b6f640e
updated from PR feedback
maffkipp Feb 15, 2024
eb13c33
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 15, 2024
90ec78b
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 15, 2024
ce64095
rewrote hook and permission structure based on feedback
maffkipp Feb 16, 2024
87ca3c5
added check for single permission
maffkipp Feb 16, 2024
3134099
persistent arg names
maffkipp Feb 16, 2024
f30a98b
additional refactor
maffkipp Feb 16, 2024
0548618
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 22, 2024
083e021
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 23, 2024
3638d03
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Feb 25, 2024
b41c63b
refactored permissions definitions
maffkipp Feb 25, 2024
132a262
resolving merge conflict
maffkipp Feb 28, 2024
d649ab4
removed fake permission
maffkipp Feb 28, 2024
ba24a0d
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Mar 5, 2024
e5f5fe2
Merge branch 'main' of github.com:SpecterOps/BloodHound into use-perm…
maffkipp Mar 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 18 additions & 1 deletion cmd/api/src/test/integration/harnesses/esc3harness3.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 18 additions & 1 deletion cmd/api/src/test/integration/harnesses/sessionharness.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
94 changes: 94 additions & 0 deletions cmd/ui/src/hooks/usePermissions/usePermissions.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
// Copyright 2024 Specter Ops, Inc.
//
// Licensed under the Apache License, Version 2.0
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// SPDX-License-Identifier: Apache-2.0

import { PermissionsAuthority, PermissionsName, PermissionsSpec } from 'bh-shared-ui';
import { renderHook } from 'src/test-utils';
import usePermissions from './usePermissions';

describe('usePermissions', () => {
const checkPermissions = (permissions: { has: PermissionsSpec[]; needs: PermissionsSpec[] }) => {
return renderHook(() => usePermissions(permissions.needs), {
initialState: {
auth: {
user: {
roles: [
{
permissions: permissions.has,
},
],
},
},
},
}).result.current;
};

const manageClientsPermission = {
authority: PermissionsAuthority.CLIENTS,
name: PermissionsName.MANAGE_CLIENTS,
};

const createTokenPermission = {
authority: PermissionsAuthority.AUTH,
name: PermissionsName.CREATE_TOKEN,
};

const manageAppConfigPermission = {
authority: PermissionsAuthority.APP,
name: PermissionsName.MANAGE_APP_CONFIG,
};

const allPermissions = [manageClientsPermission, createTokenPermission, manageAppConfigPermission];

it('permitted if the user has a required permission', () => {
const permissions = checkPermissions({
has: [manageClientsPermission],
needs: [manageClientsPermission],
});

expect(permissions.hasAll).toBe(true);
expect(permissions.hasAtLeastOne).toBe(true);
});

it('permitted if the user has multiple required permissions', () => {
const permissions = checkPermissions({
has: allPermissions,
needs: allPermissions,
});

expect(permissions.hasAll).toBe(true);
expect(permissions.hasAtLeastOne).toBe(true);
});

it('denied if the user does not have a matching permission', () => {
const permissions = checkPermissions({
has: [manageClientsPermission],
needs: [createTokenPermission],
});

expect(permissions.hasAll).toBe(false);
expect(permissions.hasAtLeastOne).toBe(false);
});

it('returns hasAtLeastOne if the user is missing one of many required permissions', () => {
const permissions = checkPermissions({
has: [manageClientsPermission, createTokenPermission],
needs: allPermissions,
});

expect(permissions.hasAll).toBe(false);
expect(permissions.hasAtLeastOne).toBe(true);
});
});
60 changes: 60 additions & 0 deletions cmd/ui/src/hooks/usePermissions/usePermissions.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Copyright 2024 Specter Ops, Inc.
//
// Licensed under the Apache License, Version 2.0
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// SPDX-License-Identifier: Apache-2.0

import { useCallback, useEffect, useState } from 'react';
import { getSelfResponse } from 'src/ducks/auth/types';
import { PermissionsSpec } from 'bh-shared-ui';
import { useAppSelector } from 'src/store';

type PermissionState = {
hasAtLeastOne: boolean;
hasAll: boolean;
};

const usePermissions: (permissions: PermissionsSpec[]) => PermissionState = (permissions) => {
const [permissionState, setPermissionState] = useState<PermissionState>({ hasAtLeastOne: false, hasAll: false });
const auth = useAppSelector((state) => state.auth);

const checkUserPermissions = useCallback(
(user: getSelfResponse): PermissionState => {
const userPermissions = user.roles.map((role) => role.permissions).flat();
let hasAtLeastOne = false;

const hasAll = permissions.every((permission) => {
return userPermissions.some((userPermission) => {
const matched =
userPermission.authority === permission.authority && userPermission.name === permission.name;

if (matched && !hasAtLeastOne) hasAtLeastOne = true;
return matched;
});
});

return { hasAtLeastOne, hasAll };
},
[permissions]
);

useEffect(() => {
if (auth.user) {
setPermissionState(checkUserPermissions(auth.user));
}
}, [auth, checkUserPermissions]);

return permissionState;
};

export default usePermissions;
144 changes: 86 additions & 58 deletions cmd/ui/src/test-utils.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2023 Specter Ops, Inc.
// Copyright 2024 Specter Ops, Inc.
//
// Licensed under the Apache License, Version 2.0
// you may not use this file except in compliance with the License.
Expand All @@ -17,7 +17,7 @@
import { createTheme } from '@mui/material/styles';
import { CssBaseline, StyledEngineProvider, ThemeProvider } from '@mui/material';
import { configureStore } from '@reduxjs/toolkit';
import { render } from '@testing-library/react';
import { render, renderHook } from '@testing-library/react';
import { createMemoryHistory } from 'history';
import { SnackbarProvider } from 'notistack';
import { QueryClient, QueryClientProvider } from 'react-query';
Expand All @@ -27,75 +27,103 @@ import createSagaMiddleware from 'redux-saga';
import { rootReducer } from 'src/store';
import { NotificationsProvider } from 'bh-shared-ui';

const defaultTheme = {
palette: {
primary: {
main: '#406f8e',
light: '#709dbe',
dark: '#064460',
contrastText: '#ffffff',
},
neutral: {
main: '#e0e0e0',
light: '#ffffff',
dark: '#cccccc',
contrastText: '#000000',
},
background: {
paper: '#fafafa',
default: '#e4e9eb',
},
low: 'rgb(255, 195, 15)',
moderate: 'rgb(255, 97, 66)',
high: 'rgb(205, 0, 117)',
critical: 'rgb(76, 29, 143)',
},
}

const createDefaultQueryClient = () => {
return new QueryClient({
defaultOptions: {
queries: {
retry: false,
},
},
})
}

const createDefaultStore = (state) => {
return configureStore({
reducer: rootReducer,
preloadedState: state,
middleware: (getDefaultMiddleware) => {
return [...getDefaultMiddleware({ serializableCheck: false }), createSagaMiddleware()];
},
})
}

const createProviders = ({ queryClient, history, theme, store, children }) => {
return (
<Provider store={store}>
<QueryClientProvider client={queryClient}>
<StyledEngineProvider injectFirst>
<ThemeProvider theme={theme}>
<NotificationsProvider>
<CssBaseline />
<Router location={history.location} navigator={history}>
<SnackbarProvider>{children}</SnackbarProvider>
</Router>
</NotificationsProvider>
</ThemeProvider>
</StyledEngineProvider>
</QueryClientProvider>
</Provider>
)
}

const customRender = (
ui,
{
initialState = {},
queryClient = new QueryClient({
defaultOptions: {
queries: {
retry: false,
},
},
}),
queryClient = createDefaultQueryClient(),
history = createMemoryHistory(),
theme = createTheme({
palette: {
primary: {
main: '#406f8e',
light: '#709dbe',
dark: '#064460',
contrastText: '#ffffff',
},
neutral: {
main: '#e0e0e0',
light: '#ffffff',
dark: '#cccccc',
contrastText: '#000000',
},
background: {
paper: '#fafafa',
default: '#e4e9eb',
},
low: 'rgb(255, 195, 15)',
moderate: 'rgb(255, 97, 66)',
high: 'rgb(205, 0, 117)',
critical: 'rgb(76, 29, 143)',
},
}),
store = configureStore({
reducer: rootReducer,
preloadedState: initialState,
middleware: (getDefaultMiddleware) => {
return [...getDefaultMiddleware({ serializableCheck: false }), createSagaMiddleware()];
},
}),
theme = createTheme(defaultTheme),
store = createDefaultStore(initialState),
...renderOptions
} = {}
) => {
const AllTheProviders = ({ children }) => {
return (
<Provider store={store}>
<QueryClientProvider client={queryClient}>
<StyledEngineProvider injectFirst>
<ThemeProvider theme={theme}>
<NotificationsProvider>
<CssBaseline />
<Router location={history.location} navigator={history}>
<SnackbarProvider>{children}</SnackbarProvider>
</Router>
</NotificationsProvider>
</ThemeProvider>
</StyledEngineProvider>
</QueryClientProvider>
</Provider>
);
};
const AllTheProviders = ({ children }) => createProviders({ queryClient, history, theme, store, children });
return render(ui, { wrapper: AllTheProviders, ...renderOptions });
};

const customRenderHook = (
hook,
maffkipp marked this conversation as resolved.
Show resolved Hide resolved
{
initialState = {},
queryClient = createDefaultQueryClient(),
history = createMemoryHistory(),
theme = createTheme(defaultTheme),
store = createDefaultStore(initialState),
...renderOptions
maffkipp marked this conversation as resolved.
Show resolved Hide resolved
} = {}
) => {
const AllTheProviders = ({ children }) => createProviders({ queryClient, history, theme, store, children });
return renderHook(hook, { wrapper: AllTheProviders, ...renderOptions });
};

// re-export everything
// eslint-disable-next-line react-refresh/only-export-components
export * from '@testing-library/react';
// override render method
export { customRender as render };
export { customRenderHook as renderHook };
1 change: 1 addition & 0 deletions packages/javascript/bh-shared-ui/src/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,4 @@ export * from './entityInfoDisplay';
export * from './passwd';
export * from './user';
export * from './icons';
export * from './permissions';
50 changes: 50 additions & 0 deletions packages/javascript/bh-shared-ui/src/utils/permissions.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
// Copyright 2024 Specter Ops, Inc.
//
// Licensed under the Apache License, Version 2.0
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// SPDX-License-Identifier: Apache-2.0

export enum PermissionsAuthority {
APP = 'app',
RISKS = 'risks',
AUTH = 'auth',
CLIENTS = 'clients',
COLLECTION = 'collection',
GRAPHDB = 'graphdb',
SAVED_QUERIES = 'saved_queries',
}

export enum PermissionsName {
READ_APP_CONFIG = 'ReadAppConfig',
WRITE_APP_CONFIG = 'WriteAppConfig',
GENERATE_REPORT = 'GenerateReport',
MANAGE_RISKS = 'ManageRisks',
CREATE_TOKEN = 'CreateToken',
MANAGE_APP_CONFIG = 'ManageAppConfig',
MANAGE_PROVIDERS = 'ManageProviders',
MANAGE_SELF = 'ManageSelf',
MANAGE_USERS = 'ManageUsers',
MANAGE_CLIENTS = 'Manage',
READ_CLIENTS = 'Read',
CLIENT_TASKING = 'Tasking',
MANAGE_COLLECTION_JOBS = 'ManageJobs',
READ_GRAPHDB = 'Read',
WRITE_GRAPHDB = 'Write',
READ_SAVED_QUERIES = 'Read',
WRITE_SAVED_QUERIES = 'Write',
}

export type PermissionsSpec = {
authority: PermissionsAuthority;
name: PermissionsName;
};
Loading