Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason why presentation definitions is an array in OID4VP? #143

Open
TimoGlastra opened this issue Aug 20, 2024 · 0 comments
Open

Reason why presentation definitions is an array in OID4VP? #143

TimoGlastra opened this issue Aug 20, 2024 · 0 comments

Comments

@TimoGlastra
Copy link
Collaborator

The spec mentions that presentation_definition or presentation_definition_uri needs to be a PD object. This library also checks that not both the presentation_definition and presentation_definition_uri are present, so I think that means presentation definitions will never be an array?

I think it could help with simplifying the presentation parsing logic if we make presentation definition an object with one entry, especially as I'm now looking to add the new multi-vp for one PD logic.

Thoughts? Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant