Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store verification result in AuthorizationResponse #151

Open
zpangrsic-eq opened this issue Oct 2, 2024 · 2 comments
Open

Store verification result in AuthorizationResponse #151

zpangrsic-eq opened this issue Oct 2, 2024 · 2 comments

Comments

@zpangrsic-eq
Copy link

We want to extend the verification of Verifiable Presentations and as so we created our own implementation of verifyPresentationCallback to be used. What we want is that the response of this callback to be stored somewhere (i think AuthorizationResponse class should store it somewhere, from what i see it is used also to fetch the status of the verification). This would make it easier to extend with additional functionality and be a little better at providing different values to be presented to the end user when they want to see the result of the verification.

https://github.com/Sphereon-Opensource/SIOP-OID4VP/blob/b7ab7418ded18ce3219813f935f94192b31fd1e9/src/authorization-response/PresentationExchange.ts#L347

Currently the code does not store whatever verificationResult returns. Storing this information would be beneficial.

@TimoGlastra
Copy link
Collaborator

#144 is similar to some part of this issue, but mostly focuses on the failed verifications, i think it would be good to have access to it in general!

FYI @zpangrsic-nchain, the siop-oid4vp repo was merged with the oid4vci repo, and now lives here: https://github.com/Sphereon-Opensource/OID4VC

@nklomp can you archive this repo and set it to read only?

@zpangrsic-eq
Copy link
Author

👍 thank you.

@nklomp nklomp transferred this issue from Sphereon-Opensource/SIOP-OID4VP Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants