Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run forever fixes #1224

Closed
wants to merge 14 commits into from
Closed

Run forever fixes #1224

wants to merge 14 commits into from

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Oct 25, 2024

Changes how run forever works with recording.

automated auto pause resume loops have been removed.

  • You could not break out of these with a stop
  • No know use case actually ran a second loop

Now run forever with record is a run and trust stop will be called on time

  • Record space is set as large as possible
  • The is a log to say how long the run can be trusted
  • A single run IE no loops is tarted

These changes allow the ChipPowerMonitors to be added

In this PR the compute energy usage INCORRECTLY assumes the runtime is 0

fixes #1228 #1229

Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine, once it is passing

@Christian-B Christian-B mentioned this pull request Nov 7, 2024
@Christian-B
Copy link
Member Author

What is still needed and not done elsewhere is in #1234

@Christian-B Christian-B closed this Nov 7, 2024
@Christian-B Christian-B deleted the run_forever_fixes branch November 7, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state changing property
2 participants