Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split run methods into smaller blocks of code. #1232

Open
Christian-B opened this issue Nov 7, 2024 · 0 comments
Open

Split run methods into smaller blocks of code. #1232

Christian-B opened this issue Nov 7, 2024 · 0 comments
Assignees

Comments

@Christian-B
Copy link
Member

ref:
The run methods have grown to be too long and complex

def __run(self, run_time: Optional[float], sync_time: float):

A better approach is to split these into three different methods for each run type

  • run timed probably also run timed looped
  • run forever
  • run until stopped

the have these call support methods where they share behaviour

@Christian-B Christian-B self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant