Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure in encoding utf8 filenames #6

Open
evilaliv3 opened this issue Jun 22, 2015 · 3 comments
Open

Failure in encoding utf8 filenames #6

evilaliv3 opened this issue Jun 22, 2015 · 3 comments

Comments

@evilaliv3
Copy link

While working on GlobaLeaks and reusing the spideroak zipstream implementation we foound out that that implementation is failing to encode utf8 filenames.

In order to fix the issue you could use the fix implemented in globaleaks/globaleaks-whistleblowing-software@5b4c994

that fix make use of standard python code present in recent zipfile.py (python 2.7/3.4)

As sidenot it would be interesting for you to know that in python3.4 the zipfile.py implementation makes possibile to use also BZIP2 and LMZA that are more efficient in the compression. Among the two it would be valuable to integrate BZIP2 that has a more high compression rate while being less cpu intensive.

@edevil
Copy link

edevil commented Jun 22, 2015

Why not do a pull request?

@evilaliv3
Copy link
Author

sure! going to do it. i was just checking that the project is still used by someone.

@edevil
Copy link

edevil commented Jun 22, 2015

At least I'm still using it. :) Thanks.

evilaliv3 added a commit to evilaliv3/ZipStream that referenced this issue Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants