Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why are the other tablists not implemented #3573

Open
3 of 4 tasks
Outfluencer opened this issue Dec 13, 2023 · 4 comments
Open
3 of 4 tasks

why are the other tablists not implemented #3573

Outfluencer opened this issue Dec 13, 2023 · 4 comments

Comments

@Outfluencer
Copy link
Collaborator

Outfluencer commented Dec 13, 2023

Feature description

We should implement them or remove them completely, but what should they actually do?
I dont really understand what GLOBAL(), GLOBAL_PING(), SERVER(); means, maybe someone can explain.

Goal of the feature

Remove this to get cleaner code or implement it so wo dont have unused enums and config options

Unfitting alternatives

.

Checking

  • This is not a question or plugin creation help request.
  • This is a feature or improvement request.
  • I have not read these checkboxes and therefore I just ticked them all.
  • I did not use this form to report a bug.
@Janmm14
Copy link
Contributor

Janmm14 commented Dec 13, 2023

With the introduction of skin data on tablist in minecraft 1.7, an eventual implementation of global tab lists got more complicated and was therefore not done.

global tablist was identical to global_ping, but without real ping display.
global would show all players on bungee in tablist.

@Outfluencer
Copy link
Collaborator Author

So should we maybe remove it completely or implement it?

@Outfluencer
Copy link
Collaborator Author

Outfluencer commented Dec 19, 2023

i wanted to add it now, but i thought about and and i don't understand how it possibly works at all.

If someone with permissions enters vanish mode and is vanished for everyone but server team members.

How should i detect if i now have to add this player to the GLOBAL tablist or not cause maybe the player has permissions to see the vanished player on the backend server and maybe not,

Example Player1 enters Vanish on Lobby1, server sends remove Player to the players, onUpdate will handle it and remove him from global tablist, Player2 who has permissions to see Player1 joins the server onUpdate is called with add player and adds the player to everyones tablist even if he dont have permission to see Player1.

Was this taken into account when it was added before? If so, was there already a Vanish api in Spigot back then?

@Janmm14
Copy link
Contributor

Janmm14 commented Dec 19, 2023

i wanted to add it now, but i thought about and and i don't understand how it possibly works at all.

If someone with permissions enters vanish mode and is vanished for everyone but server team members.

How should i detect if i now have to add this player to the GLOBAL tablist or not cause maybe the player has permissions to see the vanished player on the backend server and maybe not,

Example Player1 enters Vanish on Lobby1, server sends remove Player to the players, onUpdate will handle it and remove him from global tablist, Player2 who has permissions to see Player1 joins the server onUpdate is called with add player and adds the player to everyones tablist even if he dont have permission to see Player1.

Was this taken into account when it was added before? If so, was there already a Vanish api in Spigot back then?

Afaik it was not handled at all.
With a global tablist, bungee would manage it, display everyone connected, and a separate bungee plugin would be needed to handle vanish, maybe those existed in the past using unsafe packet send or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants