Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to add multiple "onEnter" and "onExit" scripts to a scene #43

Open
AlexBezuska opened this issue Mar 29, 2016 · 5 comments
Open

Make it possible to add multiple "onEnter" and "onExit" scripts to a scene #43

AlexBezuska opened this issue Mar 29, 2016 · 5 comments

Comments

@AlexBezuska
Copy link
Member

No description provided.

@ericlathrop
Copy link
Member

Why?

@CaldwellYSR
Copy link
Contributor

Eric beat me to it... what's the use case here?

@AlexBezuska
Copy link
Member Author

In morning ritual we had some code that needed to be run on all scenes(init) in addition to scene specific code for each scene's onEnter. This feature would let you repeat yourself less in situations like that.

@CaldwellYSR
Copy link
Contributor

This commit would do it.

@CaldwellYSR CaldwellYSR mentioned this issue Apr 1, 2016
Closed
@ericlathrop
Copy link
Member

I'm not convinced that this is necessary. If you need some base code in all enter scripts, plus some custom code, the base code could be pulled into a separate module, and require()d, which feels more like normal javascript to me. Is that more work, or more painful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ericlathrop @CaldwellYSR @AlexBezuska