Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data API Docs #335

Open
7 of 16 tasks
ghost opened this issue Sep 23, 2015 · 9 comments
Open
7 of 16 tasks

Data API Docs #335

ghost opened this issue Sep 23, 2015 · 9 comments
Labels
FLARD This is gathering dust help wanted We would appreciate contributions high priority This needs to be fixed ASAP input wanted We would like to hear your opinion
Milestone

Comments

@ghost
Copy link

ghost commented Sep 23, 2015

The Data API Docs have commenced to exist, but as gabizou put it so aptly, they merely scratch the tip of the Iceberg. Since the Data API is such a prominent feature of Sponge it deserves thorough explanation, which is mainly why the currently existing docs cover only a part of what I originally intended to write about. I'll continue to dive into the API and once I've understood enough, come back to add another page to the docs. I can in no way give an ETA or anything, so I present my To Do list here, with unmarked items free for anyone to give a shot at.

To Do List:

  • Basic stuff
  • advanced Applications
  • Using existing DataManipulators on custom Objects
  • Implementing custom DataManipulators
  • Storing Custom Data on existing DataHolders
  • Contributing
    • Implementing DataManipulators in Sponge (add DataManipulator contribution docs #321)
      • Determining if a DataManipulatoris testable without an Implementation and annotating accordingly
      • Contents of this comment
      • In step six, reflect the renaming of SpongeSerializationRegistry to the new class.
      • Add basic documentation for DualProcessors as these are currently not mentioned.

(existing, in the context of the above list, means 'existing in the SpongeAPI')

Resource List:

@ghost ghost added help wanted We would appreciate contributions input wanted We would like to hear your opinion labels Sep 23, 2015
@ghost ghost self-assigned this Sep 23, 2015
@ghost ghost added this to the Finish /plugin Pages milestone Sep 23, 2015
@Inscrutable
Copy link
Member

"if a plugin wants to have a custom data manipulator, they need to register their DataManipulatorbuilder in GameInitializeServerEvent or whatever it is" - more info from gabizou

This was referenced Nov 4, 2015
@ghost ghost removed the help wanted We would appreciate contributions label Dec 4, 2015
@ghost
Copy link
Author

ghost commented Dec 4, 2015

https://github.com/SpongePowered/SpongeAPI/pull/940/files Abstract Data in API.

@Tzky
Copy link
Contributor

Tzky commented Dec 8, 2015

We need to add a @ImplementationRequiredForTest annotation to DataManipulators (the contrib Docs), as @gabizou added a parametarized ManipulatorTest. This applies to data manipulators that deal with objects that are entirely implementation dependent; i.e. anything that is a CatalogType, Text, Entity, ItemStack etc.

example:
SpongePowered/Sponge@8671c6d#diff-4b9152d5e765fd6b123a23662ec19a44R38

@ghost ghost mentioned this issue Dec 29, 2015
2 tasks
@gabizou
Copy link
Member

gabizou commented Jan 13, 2016

Just to add some examples of working custom data. The demo plugin will create FakeData and assign it to a Player who executed the /fakeData command and the /validateData command will check that the data exists on the Player who executed it. It's rudimentary but it exemplifies what is minimally required for custom data that persists properly between world loads and server restarts.

https://gist.github.com/gabizou/4219d260b00fe8624fa2

@Tzky Tzky modified the milestones: v3.1.0, v3.0.0 Mar 9, 2016
@Inscrutable
Copy link
Member

Custom Data changes here and here. "those two should basically suffice document writing" gabizou assures me...
Also, if @Saladoc is indisposed, we might need someone new to take control of this issue.

@Tzky Tzky modified the milestones: v5.0.0, v3.1.0 May 11, 2016
@RobertHerhold RobertHerhold added the help wanted We would appreciate contributions label Jul 8, 2016
@Inscrutable Inscrutable unassigned ghost Sep 13, 2016
@Inscrutable
Copy link
Member

We can also add #559 to the omnibus of Data stuff to get down with. SpongeDocs need someone who can help get this back on track. Whomsoever shall yadda yadda ...

@ST-DDT
Copy link
Member

ST-DDT commented Aug 3, 2018

I might have a look at this once its gets a little bit colder...

@ST-DDT
Copy link
Member

ST-DDT commented Sep 4, 2018

I didn't forget it (yet). I just pushed it further down the road. Somehow I feel like this issue is a ⛰⛰⛰.
(if anyone wants to go ahead...go ahead^^)

@Inscrutable
Copy link
Member

This, and Inventories, are probably the two hardest subjects we have yet to tackle. It's been the downfall of one Editor in the past; what we really need is someone who is familiar with using it.

@Inscrutable Inscrutable modified the milestones: v5.1.0, v7.X May 15, 2020
@Inscrutable Inscrutable added the FLARD This is gathering dust label Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FLARD This is gathering dust help wanted We would appreciate contributions high priority This needs to be fixed ASAP input wanted We would like to hear your opinion
Projects
None yet
Development

No branches or pull requests

5 participants