forked from rdotnet/rdotnet
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License & other issues #5
Comments
Hi, is this fork more alive than the original (it is a few commits behind JMP75's)? I see that you defined license as BSD-2 which allows reuse without open-sourcing. Did you ever get a feed back on this license change/precision? |
Original was bsd but without explicit file.
I repacked in a single project using. NET Core build system instead of
Paket and signed dlls. Original now also uses Net Core and fewer projects.
Haven't seen that but maybe signed as well. If so I may consider dropping
the fork, since performance improvements are quite marginal and could be
achieved with Span+Unsafe.
The bigger issue is the library not working with R 3.5, upstream is working
on it (or at least has an issue), I only follow.
So nothing special in this fork, only tooling issues was fixed and Net Core
support without waiting for upstream.
…On Wed, Oct 10, 2018, 8:26 AM sbsrouteur ***@***.***> wrote:
Hi,
is this fork more alive than the original (it is a few commits behind
JMP75's)? I see that you defined license as BSD-2 which allows reuse
without open-sourcing. Did you ever get a feed back on this license
change/precision?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAd5fE7-Ls89Xb169ydDto1jsKZqYb9Oks5ujYUUgaJpZM4MIzON>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This repo is mostly repack for convenience - to simplify my workflow and dependencies with Spreads. However, I will be fixing issues like #4 and adding Spreads interop stuff right here.
I added an explicit LICENCE.txt file with BSD-2 as it was on codeplex and was linked from NuGet. I also copied DynamicInterop .cs files, since they are MIT, - to reduce binary dependencies. @jmp75 are you OK with that? BTW, what is the current status of R.NET? The upstream wasn't touched since Aug 2015...
Also I merged commits by @tpetricek and @Wei-Lu, but they are not substantial and usually big guys such as MSFT do not even require CLA for such things.
Other third-party code is mentioned here: https://github.com/Spreads/Spreads.R/blob/spreads/LICENSE.Dependencies.txt
Please reply here if anyone has any issues with this repack w.r.t licensing, attribution and etc.
The text was updated successfully, but these errors were encountered: