Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add button for "Remove Team" in battle room #420

Open
Teteros opened this issue Jun 4, 2017 · 1 comment
Open

[FR] Add button for "Remove Team" in battle room #420

Teteros opened this issue Jun 4, 2017 · 1 comment

Comments

@Teteros
Copy link
Contributor

Teteros commented Jun 4, 2017

A button under 'Add Team' or beside team name which removes a specific team would be more intuitive that current implementation which removes the last team only when there is no more players in that team.

Demo: https://streamable.com/ntz0b

@gajop gajop added this to the Evo Chobby release milestone Jun 16, 2017
gajop pushed a commit that referenced this issue Dec 13, 2017
@gajop
Copy link
Member

gajop commented Dec 13, 2017

So to revive this issue:

  1. I don't think teams should be automatically managed by the lobby in Skirmish. That leads to weird behavior as shown in that screenshot. Letting users manually add/remove teams seems like the best idea. Teams could be removed by pressing on an [X] button similar to how chat channels work

  2. In MP it's a bit more complicated because server doesn't hold team information. Furthermore, there is also automatic balancing going on, and other people changing teams on their own, so we need to clear out the empty teams, or they will flood the battle.

But, maybe we should change how we think about this, and consider that we actually aren't managing teams. We want users to be able to join a new team or add AIs to a new team, not to add teams, as that doesn't mean anything.
Those two actions could be represented by:
a) Having a "Add AI"->{Team 1, Team 2, ... Team n, New team} combobox (same with "Join"), or
b) by having a single line at the bottom of the teams that has a different color and content like "New Team [Add AI] [Join]" buttons, with join invisible if you are the only person in your current team.

I think I would prefer option b), as comboboxes aren't great for navigation in my experience. Also, having the "New team" line at the bottom makes more sense regarding the layout (it's logically next to other team/AI management options). Either way, there would be no need to manually manage teams, and the "Add Team" button can be removed.

I think I will implement option b) and ask for further comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants