Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add post summary micro variant #967

Closed
wants to merge 4 commits into from
Closed

feat: add post summary micro variant #967

wants to merge 4 commits into from

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented May 31, 2022 •
edited
Loading

resolves #966

See https://deploy-preview-967--stacks.netlify.app/product/components/post-summary/#micro

Questions

  • Should we truncate titles? If so, how many lines? (This could be handled in core as needed. Curious if we should prescribe truncation though. There's implications when it comes to vertically aligning elements within the post summary.)
  • What's the recommended title font size? (Profile currently uses body2, sidebar currently uses body1)
  • Should items include borders? (I'm assuming they can be added as needed by consumers but I'm not sure if we want to unify this.)
  • Should we include support for timestamps? Or any other optional data, for that matter? (Profile currently includes timestamp)

TODOs

  • Update documentation

Screenshot

Second draft

Below are screenshots with a couple variations (unanswered/short title/no date/no menu, longer title/short date/longest title/long date). There's more that could exist in these post summaries.

image

image

First draft

image

@dancormier dancormier added enhancement Issues requesting a feature modification or extension feature Issues requesting a new item to Stacks labels May 31, 2022
@dancormier dancormier requested a review from b-kelly May 31, 2022 20:09
@netlify
Copy link

netlify bot commented May 31, 2022 •
edited
Loading

✅ Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 41c95b1
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/62968abb3286f900081ef913
😎 Deploy Preview https://deploy-preview-967--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@paintedbicycle
Copy link
Contributor

  • I think body1 seems fine
  • Yes, the component should handle truncation
  • Do we need the Q and A icon back? And the Article and Collection icons?

@paintedbicycle
Copy link
Contributor

Looking at the profile page I think we need the icons, otherwise everything would look exactly the same. This could then also be used in places like the sidebar and in search like below

Screen Shot 2022-06-02 at 8 33 43 AM

@dancormier
Copy link
Contributor Author

I'm closing this PR since it will have many, many conflicts once #1091 is merged. We shall revisit post-PPCP refactor.

@dancormier dancormier closed this Dec 14, 2022
@b-kelly b-kelly deleted the dcormier/post-summary-micro branch January 18, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-kelly b-kelly Awaiting requested review from b-kelly

@shanefoster shanefoster Awaiting requested review from shanefoster

Assignees
No one assigned
Labels
enhancement Issues requesting a feature modification or extension feature Issues requesting a new item to Stacks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "micro" variant of post summary
2 participants
@dancormier @paintedbicycle