Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs from forked branches can't run CI tests #353

Closed
jrhender opened this issue Jan 17, 2024 · 2 comments
Closed

PRs from forked branches can't run CI tests #353

jrhender opened this issue Jan 17, 2024 · 2 comments
Assignees

Comments

@jrhender
Copy link
Collaborator

Because PRs from repo forks don't have access to GitHub secrets (see GHA docs), PRs from forked repos won't be able to pass the CI currently. This is because the pr-check CI job currently includes a step of updating the cached Coda data for tests (i.e. npm run refresh-test-data) which involves making requests to Coda, which requires the Coda authorization token. This was experienced here.

This isse was discussed on Discord here.
Proposed solution options are:

  1. Remove redownloading from GH PR check action and make a separate GH action for updating cached test data (only for manual run. This could be similar to this previous GH action that was used to commit new versions of data for semantic search
  2. Host the test cache externally (so as to remove the cache remove being directly in the repo). This is what is currently done to fetch semantic search data (fetch('https://storage.googleapis.com/stampy-nlp-resources/stampy-encodings.json') in tfWorker.js)
@jrhender jrhender self-assigned this Jan 17, 2024
@jrhender
Copy link
Collaborator Author

I plan on implementing the first solution as it is less effort than the second solution, in my opinion.

@jrhender
Copy link
Collaborator Author

jrhender commented Jul 1, 2024

This is complete from PR #354

@jrhender jrhender closed this as completed Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant