Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - global nav #424

Closed
melissasamworth opened this issue Feb 19, 2024 · 5 comments
Closed

Mobile - global nav #424

melissasamworth opened this issue Feb 19, 2024 · 5 comments
Assignees

Comments

@melissasamworth
Copy link
Contributor

Acceptance criteria

  • Before tapping menu button
    • Logo, which leads back to home page (same as desktop)
    • Menu button on left
      • The icon is 24px by 24px by ideally the click target would be 40px by 40px but without making the padding or alignment off
  • When user taps menu button on right, full screen overlay appears
    • X button takes place of menu button
    • If user taps X button they return to previous screen
    • If user taps "Articles" (make click target the entire rectangle, not just the text), load the articles dropdown mobile page
      • This functions the same as the desktop articles dropdown (somehow would be nice to reference the same component?)
      • If the user taps back arrow, go to previous screen (original menu screen)
      • If the user taps X, go back to the original screen before they tapped the menu button

Links
https://www.figma.com/file/qqfeYAh6Z7QdyJXsQjIUfh/Stampy?type=design&node-id=2807%3A20106&mode=dev&t=zTwTmuq08p9ZfsM1-1

@buddy-web3 buddy-web3 self-assigned this Feb 21, 2024
@melissasamworth
Copy link
Contributor Author

Update: mostly done, the articles dropdown part is still left

@melissasamworth
Copy link
Contributor Author

Update: Buddy needs to fix something, then he'll merge this (replace current header with new header when on mobile)

@melissasamworth melissasamworth changed the title Mobile - create global nav component Mobile - global nav Mar 6, 2024
@buddy-web3
Copy link
Member

@melissasamworth please review/approve PR: #501

@melissasamworth
Copy link
Contributor Author

update: PR pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants