Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footnote hover #688

Closed
melissasamworth opened this issue Jun 5, 2024 · 5 comments
Closed

Footnote hover #688

melissasamworth opened this issue Jun 5, 2024 · 5 comments
Assignees

Comments

@melissasamworth
Copy link
Contributor

melissasamworth commented Jun 5, 2024

Acceptance criteria

  • Footnote superscripts have no brackets (already done)
  • They are the standard green color
  • When user hovers over the number, show the footnote hover
    • Style should match design
  • When user clicks the number, scroll down so that the start of the footnote is at the top of the user's screen
  • For mobile, do the same as for the reference hovers in the chabot
    • The acceptance criteria for this:
      When user taps on a reference number in a bot response, the position of the page shifts so that the number tapped is 16px from the top of the screen, and the popover is below it
      Clicking anywhere outside the popover closes it out, until then keep it open
      If the popover goes past the length the screen, make sure user can scroll and still read the whole thing
      Note that there may be an issue if the number is at the end and the popover is very long. I'm hoping with the additional questions at the bottom creating space, this doesn't happen often. So ignore this edge case for now.

Image

Note that this task was created for the bot, but ideally it addresses the entire site

LInks
Figma

@bryceerobertson
Copy link
Member

@mruwnik I think these should all be the normal green

Image

@bryceerobertson
Copy link
Member

@zarSou9 the footnote numbers are still showing up as multicolored for me?

Image

@zarSou9
Copy link
Contributor

zarSou9 commented Jun 13, 2024

I think the multicolored is good. It helps differentiate between footnotes, and it looks pretty imho

@bryceerobertson
Copy link
Member

Fair enough, better let @melissasamworth have the final say though.

@mruwnik
Copy link
Collaborator

mruwnik commented Jun 18, 2024

I also like the colours, for the same reasons

@bryceerobertson bryceerobertson removed their assignment Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants