[BugFix] should acquire db lock out of createLoadTask to avoid dead lock (backport #55219) #55264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
A dead lock issue is found:
Slow lock:
Thread "pool-21-thread-406" owns the database lock.
StreamLoadMgr.cleanSyncStreamLoadTasks()
tries to acquireStreamLoadMgr.lock.writeLock()
0x00007fb9905311a8Jstack:
Thread "thrift-server-pool-6208" owns the StreamLoadMgr.lock.writeLock(): 0x00007fb9905311a8 in
StreamLoadMgr.beginLoadTask()
StreamLoadMgr.beginLoadTask()
callStreamLoadMgr.createLoadTask()
who is trying to acquire database lockWhat I'm doing:
StreamLoadMgr.createLoadTask()
don't acquire database lock.StreamLoadMgr.beginLoadTask()
first acquire database lock and unlock, then acquireStreamLoadMgr.lock.writeLock()
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?