You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although the library may no longer be maintained and will not compile in my current environment, I intend to report the issue for reference only. Description
consider the two functions above, they use unsafe API from_raw_parts and from_raw_parts_mut, however, the Environment is a pub struct which means the user can directly manipulate its values_ptr and values_count fields, which are also pub, and pass directly into the unsafe API, so I believe there is a health issue here.
The text was updated successfully, but these errors were encountered:
Although the library may no longer be maintained and will not compile in my current environment, I intend to report the issue for reference only.
Description
starlight/crates/starlight/src/vm/environment.rs
Line 43 in 503e789
starlight/crates/starlight/src/vm/environment.rs
Line 47 in 503e789
consider the two functions above, they use unsafe API
from_raw_parts
andfrom_raw_parts_mut
, however, the Environment is a pub struct which means the user can directly manipulate its values_ptr and values_count fields, which are also pub, and pass directly into the unsafe API, so I believe there is a health issue here.The text was updated successfully, but these errors were encountered: