New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

catch non-json exceptions and throw/reject appropriately #24

Open

dangoscomb wants to merge 1 commit into StarryShark:master from dangoscomb:master

dangoscomb commented Jun 29, 2020

This catches errors correctly when JSON is not returned from the server (such as when you get 404s, 500s, etc)

fixes #21


          catch non-json exceptions and throw/reject appropriately

26bf725

giovaninogueira approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet