Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Convert to Material UI #15

Closed
KaneFreeman opened this issue Oct 2, 2022 · 3 comments
Closed

Convert to Material UI #15

KaneFreeman opened this issue Oct 2, 2022 · 3 comments
Assignees
Milestone

Comments

@KaneFreeman
Copy link
Collaborator

Switch to material UI

@KaneFreeman KaneFreeman moved this to In Progress in Static CMS Oct 2, 2022
@KaneFreeman KaneFreeman self-assigned this Oct 2, 2022
@KaneFreeman KaneFreeman mentioned this issue Oct 2, 2022
11 tasks
@KaneFreeman KaneFreeman added this to the v1.0.0 milestone Oct 6, 2022
@DavidWells
Copy link

This project looks cool. Thanks for this fork!

Quick question: What's the idea behind using MUI for this?

Those components are pretty beefy https://bundlephobia.com/package/@mui/[email protected] bundlesize wise.

Here are a couple of other potentially lighter-weight alternatives:

Anywho, totally up to you, just thought I'd share some component libs that might help.

@KaneFreeman
Copy link
Collaborator Author

So the choice of Material UI comes down to a combination of my familiarity with the library (I have been using it for years), it covers a lot of the scenarios we need (and some I want to add) and my own personal preference towards Material Design in general.

Switching to it has allowed me to remove several other independent dependencies and drastically reducing the size of our own code base (as a lot of the styling previously was custom). This will help a lot with maintaining the code base. It also is build on top of @emotion which the repo was already using. And yes bundle size is a concern still and I am taking steps to reduce it at much as possible (see: https://mui.com/material-ui/guides/minimizing-bundle-size/).

Here are a few other benefits the library gives:

  • Accessibility (a lot of effort has been put into the material ui library on this front, including great keyboard support for its components)
  • Great support for mobile (which I am planning to add Mobile support #16 )
  • Extremely easy to implement Dark mode (which is on my list to add eventually)

@KaneFreeman KaneFreeman mentioned this issue Oct 19, 2022
52 tasks
@KaneFreeman
Copy link
Collaborator Author

Resolved in #44

Repository owner moved this from In Progress to Done in Static CMS Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants