-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UpdateTunnel deck to 1.0.4 #689
UpdateTunnel deck to 1.0.4 #689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkohler616 please make sure to go back through package.json and or plugin.json and properly denote the plugin's original author and to remove his name from the email which you have changed over to your own. I have no problem allowing this PR to continue if this is done. Once this is done the plugin will be good to proceed to the testing store.
My bad on that one - he has been properly added as a contributor, and I guess I'm the "author" now. If you want me to set him back as the author I can, just lemme know. |
If Steve wishes to retake the project then we differ to the original developer within our discussion so all good atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for testing.
small suggestion to reduce shutdown times (applies to previous versions too): you really don't need to restart networkmanager on shutdown when the openvpn extension isn't enabled in the first place |
Gotcha, I'll have that done in next version. |
Hiya. Couple of things.
Here's my testing report if that's valid or not:
D) Yay*
|
yes it's the uninstall script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testers approve! Off to production.
@bkohler616 apologies but I just realized that you were the original PR author and I didn't realize that. In future you do need another user to properly fill out the testing form in future. |
@TrainDoctor Sorry, I didn't mean to rush you on that front - my apologies. I also don't really have known people that can test for me (I kinda suck at talking 😅) I put up a new one, so hopefully I can get it right this time. I'll poke the community for a tester that may wanna help me out. And again, super sorry my man :( |
Nothing to apologize for though I appreciate the thought. It's on me to better review the comments in these PRs and verify that proper procedure is being followed. You even asked whether this testing report was valid in the comment lol. |
TunnelDeck
Checklist:
Developer Checklist
Plugin Checklist
Plugin Backend Checklist
Testing