Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 step import not happening #1295

Open
thompson-tomo opened this issue May 11, 2024 · 2 comments
Open

2 step import not happening #1295

thompson-tomo opened this issue May 11, 2024 · 2 comments
Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Status/needs-investigation Tickets needs more investigation Type/enhancement New feature or request

Comments

@thompson-tomo
Copy link
Contributor

Describe the bug

The 2 stage approach of fetching config from config server is not happening

Steps to reproduce

Steps to reproduce the behavior:

  1. Setup steeltoe to talk to a config server
  2. Observe traffic to config server
  3. Verify that a second request is not processed using the config returned for the default

Expected behavior

I expect to be able to perform a get config for the default profile of my application which then informs the application of additional profiles which are active as mentioned in the spring cloud docs.

Environment (please complete the following information):

  • Steeltoe Version [3.2.6]
  • Platform: [e.g. Cloud Foundry, Azure, etc.)
  • OS: Windows,
  • .NET Version Net 8

Additional context or links

Add any other context about the problem here.

@thompson-tomo thompson-tomo added the Type/bug Something isn't working label May 11, 2024
@TimHess TimHess added Type/enhancement New feature or request Component/Configuration Issues related to Configuration providers Status/needs-investigation Tickets needs more investigation ReleaseLine/4.x Identified as a feature/fix for the 4.x release line and removed Type/bug Something isn't working labels May 13, 2024
@TimHess
Copy link
Member

TimHess commented May 13, 2024

Hi @thompson-tomo,

This approach has never been supported in Steeltoe, this is the first time I've heard anyone requesting it from the .NET side. We would need to do some more investigation to find out what the best approach would be if it does indeed make sense to support it.

@thompson-tomo
Copy link
Contributor Author

Hi @TimHess no worries it ain a high priority request but more a nice to have after reading the docs.

In the end what I would see is that my apps are bootstrapped with minimal config ie app name, config server address from which the default profile is fetched. This profile is inspected & if there is a new active profiles element a secondary fetch is performed. I would limit it 2 steps & not do it recursively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Configuration Issues related to Configuration providers ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Status/needs-investigation Tickets needs more investigation Type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants