Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong character in Meade LX200 comand #3451

Closed
labrat0638 opened this issue Oct 8, 2023 · 11 comments
Closed

Wrong character in Meade LX200 comand #3451

labrat0638 opened this issue Oct 8, 2023 · 11 comments
Assignees
Labels
opinion OP thinks something should behave differently
Milestone

Comments

@labrat0638
Copy link

labrat0638 commented Oct 8, 2023

I checked serial port communication in telescope control plugin. Since I made and build own GOTO implementation (on Arduino) it worked flawlessly in Stellarium with Meade LX200 protocol. Until problems with Qt6 versions. Now it mainly fixed, congratulations. But now I noticed Arduino does not react properly on sent by Stellarium target coordinates. I sniffed USB communication with program Device Monitoring Studio. Now Stellarium uses weird character instead [*] in this command: :SdsDD*MM:SS#. (Look into attachments)

Expected Behaviour

Comand in old version

This is implementation according to known to me MEADE LX200 protocol documentation. ( I older versions like: 0.20.2)

Actual Behaviour

Comand in new version

This is implementation with not expected sign (in Stellarium 23.3)

System

  • Stellarium version: stellarium-23.3-qt6-win64

  • Operating system: Windows 10

@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Thanks for adding your first issue to Stellarium. If you have questions, please do not hesitate to contact us.

@alex-w alex-w added this to the 23.4 milestone Oct 8, 2023
@alex-w alex-w added the bug Something likely wrong in the code label Oct 8, 2023
@alex-w
Copy link
Member

alex-w commented Oct 8, 2023

Please attach your LX200 protocol documentation

@10110111
Copy link
Contributor

10110111 commented Oct 8, 2023

Here is the source of this character in Stellarium's output:

	p[-6] = '\xDF'; // = 223, degree symbol. This is always printed as asterisk in the specs, very confusing.

@labrat0638
Copy link
Author

@10110111
Copy link
Contributor

10110111 commented Oct 8, 2023

Here we can also find the discussion of ° sign denoted by * in the manuals:

the degree symbol (ASCII 223 '°' [0xdf]) non-terminal is used as the separator character in degrees and minutes. This character is shown as an asterisk (ASCII 0x2a '*') in the manual for both the 16-inch and smaller telescopes and is followed by a note in the manual describing the ASCII value of the character.

@10110111
Copy link
Contributor

10110111 commented Oct 8, 2023

Finally, your second document discusses the meaning of the asterisk in Commands section on page 2.

@labrat0638
Copy link
Author

labrat0638 commented Oct 8, 2023

So, this mean the older versions of Stellarium had wrong implementation. Thanks for quick response.

@gzotti
Copy link
Member

gzotti commented Oct 8, 2023

Groundhog day? Years ago I found a mismatch between code and specs, tried to repair according to the specs. Users complained this broke the program. We reverted, and all users were happy again. Now a problem appears in some Arduino implementation. Is the program currently working with genuine LX200 systems?

@labrat0638
Copy link
Author

labrat0638 commented Oct 8, 2023

Groundhog day? Years ago I found a mismatch between code and specs, tried to repair according to the specs. Users complained this broke the program. We reverted, and all users were happy again. Now a problem appears in some Arduino implementation. Is the program currently working with genuine LX200 systems?

Exactly, I can adapt my Arduino project to current Stellarium implementation, but owners of Meade Telescopes not so much.

@gzotti gzotti added opinion OP thinks something should behave differently and removed bug Something likely wrong in the code labels Oct 8, 2023
@gzotti
Copy link
Member

gzotti commented Dec 8, 2023

Can we close this?

@alex-w alex-w modified the milestones: 23.4, 24.1 Dec 23, 2023
@gzotti
Copy link
Member

gzotti commented Dec 23, 2023

We can presumably close this as resolved. The "unexpected" character 223 is actually required.

@gzotti gzotti closed this as completed Dec 23, 2023
@gzotti gzotti self-assigned this Dec 23, 2023
@alex-w alex-w modified the milestones: 24.1, 23.4 Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion OP thinks something should behave differently
Development

No branches or pull requests

4 participants