Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eta Carinae should be labeled with a name. #633

Open
sunshuwei opened this issue Feb 18, 2019 · 6 comments
Open

Eta Carinae should be labeled with a name. #633

sunshuwei opened this issue Feb 18, 2019 · 6 comments
Assignees
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality state: confirmed A developer can reproduce the issue state: in progress The problem is in process of solution...
Milestone

Comments

@sunshuwei
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Eta Carinae is an important star, but it is not labeled with a name.
Describe the solution you'd like
Eta Carinae should be labeled with a name. It is HR 4210, HD 93308

Additional context
Add any other context or screenshots about the feature request here.
111

@alex-w
Copy link
Member

alex-w commented Feb 18, 2019

Eta Carinae hasn't HIP designation and we cannot add any labels to any stars without HIP designations currently.

@alex-w alex-w added bug Something likely wrong in the code enhancement Improve existing functionality state: confirmed A developer can reproduce the issue labels Feb 18, 2019
@sunshuwei
Copy link
Contributor Author

I guess the same is true. Why can't use another catalog as an alternatives?

@gzotti
Copy link
Member

gzotti commented Feb 19, 2019

The star catalog and cross-referencing uses Hipparcos as only key reference because HIP was by far the best reference 15 years ago and is (well, almost!) complete with reasonably bright stars. Replacing the star catalog is a major undertaking, which should happen within the next 5 years or so for various reasons. Astrometry has a new gold mine with Gaia data, which however does not contain bright stars. Somebody needs to take the time for developing an efficient data storage format for stars.

@gzotti gzotti added data Missing/bad/outdated data, but no code error and removed bug Something likely wrong in the code labels Feb 19, 2019
@axd1967
Copy link
Contributor

axd1967 commented Dec 10, 2019

I think there is another bug. I've noticed that on some occasions, even the brightest stars do not get their name, but only the greek name (α-boo instead of Arcturus, α-CMa insteed of Sirius), despite Name being set in the Settings>Information>Displayed fields dialog.

It's as if something happens in parallel and doesn't complete in time. When I start Stellarium, the first thing I usually do is halt time, and for a while, I had the impression that doing this too quickly contributed to this glitch (although I see no immediate reason for this). I inspected the log but saw no suspect warnings ("loaded .* star names"). When this happens, I cannot find the star either, e.g. the Find dialog does not show Sirius.

This also resembles #831

@alex-w alex-w self-assigned this Jan 12, 2021
@alex-w alex-w added this to the 24.4 milestone Nov 14, 2024
@alex-w alex-w closed this as completed in 89e971d Nov 14, 2024
@alex-w
Copy link
Member

alex-w commented Nov 14, 2024

As a temporary solution the designation for η Car star has been added via Missing Stars plugin

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 18, 2024
Copy link

Hello @sunshuwei!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w reopened this Dec 11, 2024
@alex-w alex-w modified the milestones: 24.4, 25.1 Dec 11, 2024
@alex-w alex-w added state: in progress The problem is in process of solution... and removed state: published The fix has been published for testing in weekly binary package labels Dec 11, 2024
@Stellarium Stellarium deleted a comment from github-actions bot Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Missing/bad/outdated data, but no code error enhancement Improve existing functionality state: confirmed A developer can reproduce the issue state: in progress The problem is in process of solution...
Development

No branches or pull requests

4 participants