Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tileRequestLimit: limit concurrent connections #36

Open
StephanGeorg opened this issue Mar 26, 2020 · 5 comments
Open

tileRequestLimit: limit concurrent connections #36

StephanGeorg opened this issue Mar 26, 2020 · 5 comments
Labels

Comments

@StephanGeorg
Copy link
Owner

StephanGeorg commented Mar 26, 2020

Due to new limitations of the OSM tiles usage policy I added tilesRequestLimit in [email protected] option to limit concurrent connections to the tiles server. This value is set to 2 by default and can be overwritten or disabled with tilesRequestLimit: 0.

@StephanGeorg
Copy link
Owner Author

@OlivierKamers FYI

@OlivierKamers
Copy link
Contributor

Nice 👍
I also saw the update to get rid of the request library. I played around with it a few weeks ago because we had issues parallelising multiple map renderings. I added an option to provide a custom tile loader function (so we can use our blob storage functions and some memoization) but it looks like the got library you're using now might already take care of the issues we had. I haven't been able to clean up the implementation yet so that's why I didn't propose the change here, and it's just on a branch in our fork: Sitemark@5084341

@StephanGeorg
Copy link
Owner Author

What kind of issues?

@OlivierKamers
Copy link
Contributor

I had to limit the number of requests to avoid timeouts from the request library. Externalising the function also allowed me to use a cache for tiles that are requested more than once.

@StephanGeorg
Copy link
Owner Author

Ok, that could indeed be an improvement. I thought for now caching should be done at the tiles server side, for example via CDN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants